You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/06/13 16:06:17 UTC
Review Request 35425: libprocess: Use CHECK_NONE.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35425/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos
Description
-------
Used `grep -r "CHECK([^!].*.isNone())" .` to find the instances that look like `CHECK(x.isNone());`
Diffs
-----
3rdparty/libprocess/src/decoder.hpp 56adde07b650984de367fb861d7a496fa37884cb
Diff: https://reviews.apache.org/r/35425/diff/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 35425: libprocess: Use CHECK_NONE.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35425/#review87831
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On June 13, 2015, 2:06 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35425/
> -----------------------------------------------------------
>
> (Updated June 13, 2015, 2:06 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Used `grep -r "CHECK([^!].*.isNone())" .` to find the instances that look like `CHECK(x.isNone());`
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/src/decoder.hpp 56adde07b650984de367fb861d7a496fa37884cb
>
> Diff: https://reviews.apache.org/r/35425/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>