You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by bourneagain <gi...@git.apache.org> on 2015/06/30 20:12:25 UTC

[GitHub] storm pull request: STORM-919 Gathering worker and supervisor proc...

GitHub user bourneagain opened a pull request:

    https://github.com/apache/storm/pull/608

    STORM-919 Gathering worker and supervisor process information (CPU/Memory)

    - Changes to the worker and supervisor heartbeats to carry the system stats ( CPU util % and JVM memory stats in KB ) .
    - Changes to the SystemBolt.java to include CPU metrics.
    - Tested the changes by running on the local mode ( Mac )
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bourneagain/storm STORM-919

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/608.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #608
    
----
commit 770983b889540bfb6e0ab453387da95c3bb00100
Author: Shyam Rajendran <sr...@yahoo-inc.com>
Date:   2015-06-29T21:54:46Z

    STORM-919: Gathering worker and supervisor process information (CPU/Memory)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-919 Gathering worker and supervisor proc...

Posted by bourneagain <gi...@git.apache.org>.
Github user bourneagain commented on the pull request:

    https://github.com/apache/storm/pull/608#issuecomment-118634483
  
    Thanks @lazyval . I shall keep that in mind going forward. For review we can omit all those under the "generated" directory. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-919 Gathering worker and supervisor proc...

Posted by bourneagain <gi...@git.apache.org>.
Github user bourneagain commented on the pull request:

    https://github.com/apache/storm/pull/608#issuecomment-127623505
  
    I will revert the changes to Thrift generated files and update the pull request. Also I have updated details on how we plan to use these metrics @ https://issues.apache.org/jira/browse/STORM-919. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-919 Gathering worker and supervisor proc...

Posted by lazyval <gi...@git.apache.org>.
Github user lazyval commented on the pull request:

    https://github.com/apache/storm/pull/608#issuecomment-118050871
  
    It might be too late for this particular PR, but it makes sense to separate human changes and generated code into two separate commits. Otherwise it's really hard to review the code. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-919 Gathering worker and supervisor proc...

Posted by bourneagain <gi...@git.apache.org>.
Github user bourneagain commented on the pull request:

    https://github.com/apache/storm/pull/608#issuecomment-132722067
  
    *** PLEASE DO NOT MERGE THIS YET **** 
    More information @ https://issues.apache.org/jira/browse/STORM-919. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] storm pull request: STORM-919 Gathering worker and supervisor proc...

Posted by ptgoetz <gi...@git.apache.org>.
Github user ptgoetz commented on the pull request:

    https://github.com/apache/storm/pull/608#issuecomment-171049571
  
    @bourneagain Any update on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---