You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2013/02/20 12:05:22 UTC
svn commit: r1448074 - in /commons/proper/net/trunk/src: changes/changes.xml
main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java
main/java/org/apache/commons/net/smtp/SMTPSClient.java
Author: sebb
Date: Wed Feb 20 11:05:22 2013
New Revision: 1448074
URL: http://svn.apache.org/r1448074
Log:
NET-503 AuthenticatingSMTPClient does not support non-default encoding
Modified:
commons/proper/net/trunk/src/changes/changes.xml
commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java
commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTPSClient.java
Modified: commons/proper/net/trunk/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/changes/changes.xml?rev=1448074&r1=1448073&r2=1448074&view=diff
==============================================================================
--- commons/proper/net/trunk/src/changes/changes.xml (original)
+++ commons/proper/net/trunk/src/changes/changes.xml Wed Feb 20 11:05:22 2013
@@ -64,6 +64,9 @@ The <action> type attribute can be add,u
<body>
<release version="3.3" date="TBA" description="
">
+ <action issue="NET-503" dev="sebb" type="add">
+ AuthenticatingSMTPClient does not support non-default encoding
+ </action>
<action issue="NET-500" dev="sebb" type="fix">
Always call FTPClient#setFileType after connection.
Not all servers default to ASCII.
Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java?rev=1448074&r1=1448073&r2=1448074&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/AuthenticatingSMTPClient.java Wed Feb 20 11:05:22 2013
@@ -55,6 +55,16 @@ public class AuthenticatingSMTPClient ex
super(protocol);
}
+ /**
+ * Overloaded constructor that takes a protocol specification and encoding
+ * @param protocol The protocol to use
+ * @param encoding The encoding to use
+ * @throws NoSuchAlgorithmException
+ */
+ public AuthenticatingSMTPClient(String protocol, String encoding) throws NoSuchAlgorithmException {
+ super(protocol, false, encoding);
+ }
+
/***
* A convenience method to send the ESMTP EHLO command to the server,
* receive the reply, and return the reply code.
Modified: commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTPSClient.java
URL: http://svn.apache.org/viewvc/commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTPSClient.java?rev=1448074&r1=1448073&r2=1448074&view=diff
==============================================================================
--- commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTPSClient.java (original)
+++ commons/proper/net/trunk/src/main/java/org/apache/commons/net/smtp/SMTPSClient.java Wed Feb 20 11:05:22 2013
@@ -108,6 +108,19 @@ public class SMTPSClient extends SMTPCli
}
/**
+ * Constructor for SMTPSClient.
+ * @param proto the protocol.
+ * @param implicit The security mode, {@code true} for implicit, {@code false} for explicit
+ * @param encoding the encoding
+ */
+ public SMTPSClient(String proto, boolean implicit, String encoding)
+ {
+ super(encoding);
+ protocol = proto;
+ isImplicit = implicit;
+ }
+
+ /**
* Constructor for SMTPSClient, using {@link #DEFAULT_PROTOCOL} i.e. TLS
* @param implicit The security mode, {@code true} for implicit, {@code false} for explicit
* @param ctx A pre-configured SSL Context.