You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "kinow (via GitHub)" <gi...@apache.org> on 2023/04/06 09:41:04 UTC

[GitHub] [commons-lang] kinow commented on pull request #1047: [LANG-1681] - fix some javadoc on FieldUtils methods

kinow commented on PR #1047:
URL: https://github.com/apache/commons-lang/pull/1047#issuecomment-1498775587

   Hi @dvmarcilio 
   
   >I'm rerunning the tool on the latest commit. I'll be happy to submit more PRs fixing what it finds. Then we can finally close LANG-1681.
   >Should I submit one PR per class or a single (possibly large) PR for all findings?
   
   That could result in a lot of similar PRs, which would spam others that follow every message/commit/etc sent to the ASF mailing lists. Would you be able to provide this list here? Then @laurentschoelens can see whether that can be added to this PR, or maybe you could send an extra commit/diff here.
   
   As for the missing throws I think we can also add it here (noting that we have to verify first whether we document every runtime error or not - some libraries may decide to document everything, while others document only a few like NPE, IllegalArgument, etc).
   
   Cheers
   Bruno


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org