You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/16 00:24:26 UTC
[GitHub] [airflow] potiuk opened a new pull request #14815: Fixes some of the flaky tests in test_scheduler_job (setUp/TearDown)
potiuk opened a new pull request #14815:
URL: https://github.com/apache/airflow/pull/14815
The Parallel tests from #14531 created a good opportunity to
reproduce some of the race conditions that cause some of the
scheduler job test to be flaky.
This change is an attempt to fix three of the flaky tests
there by removing side effects between tests. The previous
implementation did not take into account that scheduler job
processes might still be running when the test finishes and
the tests could have unintended side effects - especially
when they were run on a busy machine.
This PR adds mechanism that stops all running
schedulerJob processes in tearDown before cleaning
the database.
Fixes: #14778
Fixes: #14773
Fixes: #14772
Fixes: #14771
Fixes: #11571
Fixes: #12861
Fixes: #11676
Fixes: #11454
Fixes: #11442
Fixes: #11441
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #14815: Fixes some of the flaky tests in test_scheduler_job (setUp/TearDown)
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #14815:
URL: https://github.com/apache/airflow/pull/14815#issuecomment-799850437
This is variant of the "scheduler" tests with explicit setup/tearDown in tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #14815: Fixes some of the flaky tests in test_scheduler_job (setUp/TearDown)
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #14815:
URL: https://github.com/apache/airflow/pull/14815#issuecomment-799850437
This is variant of the "scheduler" flaky tests fix with explicit setUp/tearDown in tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #14815: Fixes some of the flaky tests in test_scheduler_job (setUp/TearDown)
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #14815:
URL: https://github.com/apache/airflow/pull/14815
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org