You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ignite.apache.org by "Ignite TC Bot (Jira)" <ji...@apache.org> on 2020/04/01 08:20:00 UTC

[jira] [Commented] (IGNITE-12802) Move checkpoint state fields to CheckpointProgress

    [ https://issues.apache.org/jira/browse/IGNITE-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17072505#comment-17072505 ] 

Ignite TC Bot commented on IGNITE-12802:
----------------------------------------

{panel:title=Branch: [pull/7589/head] Base: [master] : No blockers found!|borderStyle=dashed|borderColor=#ccc|titleBGColor=#D6F7C1}{panel}
[TeamCity *--&gt; Run :: All* Results|https://ci.ignite.apache.org/viewLog.html?buildId=5174988&amp;buildTypeId=IgniteTests24Java8_RunAll]

> Move checkpoint state fields to CheckpointProgress
> --------------------------------------------------
>
>                 Key: IGNITE-12802
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12802
>             Project: Ignite
>          Issue Type: Improvement
>            Reporter: Alexey Goncharuk
>            Assignee: Stanilovsky Evgeny
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> This is a review follow-up for IGNITE-7792. I've noticed that quite a few fields in {{GridCacheDatabaseSharedManager}} are related to the state of current checkpoint:
> {code}
> writtenPagesCntr
> syncedPagesCntr
> evictedPagesCntr
> currCheckpointPagesCnt
> {code}
> After checkpoint is completed, these fields are reset. On the other hand, we have a separate class to track the state of current checkpoint: {{CheckpointProgressImpl}}. I believe it makes sense to move these fields to the separate class. Perhaps, it also makes sense to make this class a top-level class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)