[GitHub] [rocketmq] WSYwsy22 opened a new pull request, #6260: fix rocketmq-proxy does not work properly in k8s nodePort mode

["WSYwsy22 (via GitHub)" <gi...@apache.org>]

WSYwsy22 opened a new pull request, #6260:
URL: https://github.com/apache/rocketmq/pull/6260

   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
     When deploying rocketmq in self-built k8s, if nodePort is used, if the port of nodePort is inconsistent with the port of proxy grpcServerPort, it will result in failure to obtain information normally from rocketmq-proxy
     This submission is to use the port that the addressList adds to address as the port that the user connects to endPoint, so that it can work compatible with the nodePort of k8s
   
   <!--
   If this PR fixes a GitHub issue, please add `fixes #<XXX>` or `closes #<XXX>`. Please refer to the documentation for more information:
   https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
   -->
   
   ## Brief changelog
   change RouteActivity#convertToAddressList
   
   
   ## Verifying this change
   You can compare the changed versions before and after. Build a k8s cluster by yourself, deploy a rocketmq cluster in it, use the nodePort mode of k8s, keep the port of nodePort mode different from the proxy grpcServerPort, and try to send and receive messages to verify
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] WSYwsy22 closed pull request #6260: fix rocketmq-proxy does not work properly in k8s nodePort mode

["WSYwsy22 (via GitHub)" <gi...@apache.org>]

WSYwsy22 closed pull request #6260: fix rocketmq-proxy does not work properly in k8s nodePort mode
URL: https://github.com/apache/rocketmq/pull/6260


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org