You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by tgroh <gi...@git.apache.org> on 2016/10/07 20:04:12 UTC

[GitHub] incubator-beam pull request #1066: Revert "Place fired timers in the Global ...

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1066

    Revert "Place fired timers in the Global Window"

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    This reverts commit 8d659fec13982c982d58d8abd1007197bc443c61.
    
    This change has caused `TopWikipediaSessionsTest` to become flaky.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam revert_global_window_timers

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1066.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1066
    
----
commit a9fadc23c9893831a26a47b1cd679474d361feca
Author: Thomas Groh <tg...@google.com>
Date:   2016-10-07T19:36:19Z

    Revert "Place fired timers in the Global Window"
    
    This reverts commit 8d659fec13982c982d58d8abd1007197bc443c61.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-beam pull request #1066: Revert "Place fired timers in the Global ...

Posted by tgroh <gi...@git.apache.org>.
Github user tgroh closed the pull request at:

    https://github.com/apache/incubator-beam/pull/1066


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---