You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/06/26 03:41:13 UTC
Review Request 22995: Fixed DRFAllocatorTest.SameShareAllocations test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22995/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-1544
https://issues.apache.org/jira/browse/MESOS-1544
Repository: mesos-git
Description
-------
The bug here is that first framework can match the 'frameworkAdded' expectation that was setup for the second framework.
Diffs
-----
src/tests/allocator_tests.cpp a968ea3ed3a8485b3a83795c0b661e7d1e5b68fa
Diff: https://reviews.apache.org/r/22995/diff/
Testing
-------
make check GTEST_FILTER="*DRFAllocatorTest.SameShareAllocations*" GTEST_REPEAT=10
Thanks,
Vinod Kone
Re: Review Request 22995: Fixed DRFAllocatorTest.SameShareAllocations test.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22995/#review46709
-----------------------------------------------------------
Patch looks great!
Reviews applied: [22995]
All tests passed.
- Mesos ReviewBot
On June 26, 2014, 1:41 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22995/
> -----------------------------------------------------------
>
> (Updated June 26, 2014, 1:41 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1544
> https://issues.apache.org/jira/browse/MESOS-1544
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The bug here is that first framework can match the 'frameworkAdded' expectation that was setup for the second framework.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp a968ea3ed3a8485b3a83795c0b661e7d1e5b68fa
>
> Diff: https://reviews.apache.org/r/22995/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER="*DRFAllocatorTest.SameShareAllocations*" GTEST_REPEAT=10
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 22995: Fixed DRFAllocatorTest.SameShareAllocations test.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22995/#review46710
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On June 26, 2014, 1:41 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22995/
> -----------------------------------------------------------
>
> (Updated June 26, 2014, 1:41 a.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-1544
> https://issues.apache.org/jira/browse/MESOS-1544
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> The bug here is that first framework can match the 'frameworkAdded' expectation that was setup for the second framework.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp a968ea3ed3a8485b3a83795c0b661e7d1e5b68fa
>
> Diff: https://reviews.apache.org/r/22995/diff/
>
>
> Testing
> -------
>
> make check GTEST_FILTER="*DRFAllocatorTest.SameShareAllocations*" GTEST_REPEAT=10
>
>
> Thanks,
>
> Vinod Kone
>
>