[jira] Commented: (DERBY-2309) Add build.xml, so that the code can get compiled using ant with the 'all' target.

["Andrew McIntyre (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DERBY-2309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472929 ] 

Andrew McIntyre commented on DERBY-2309:
----------------------------------------

Hi Manjula, took a look at the patch. It looks good, one minor problem: I think you forgot to add a <copy> task for the resource jar in the build file for sttest. 

I note that after applying this patch, derbyTesting.jar in the jar build is now 11MB. I'd suggest working on DERBY-2311 next to bring the size of the derbyTesting.jar file back down.

I'll hold off on committing this patch for a little while in case anyone objects to the increase in the jar file size.

> Add build.xml, so that the code can get compiled using ant with the 'all' target.
> ---------------------------------------------------------------------------------
>
>                 Key: DERBY-2309
>                 URL: https://issues.apache.org/jira/browse/DERBY-2309
>             Project: Derby
>          Issue Type: Sub-task
>          Components: Test
>    Affects Versions: 10.3.0.0
>            Reporter: Manjula Kutty
>         Assigned To: Manjula Kutty
>            Priority: Minor
>             Fix For: 10.3.0.0
>
>         Attachments: DERBY-2309_diff.txt, DERBY-2309_stat.txt
>
>
> Place holder for adding build.xml. Also I propose here to create derbySysTest.jar instead of putting all the system test classes in the derbyTesting.jar. By doing that people who wish to run the system test only need to download them. All comments and suggestions are welcome

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.