You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/10/10 02:07:58 UTC

[GitHub] [incubator-seatunnel] hailin0 commented on a diff in pull request #3046: [Feature][Connector-V2][Iceberg]Modify the scope of flink-shaded-hadoop-2 to provided to be compatible with hadoop3.x

hailin0 commented on code in PR #3046:
URL: https://github.com/apache/incubator-seatunnel/pull/3046#discussion_r990878278


##########
docs/en/connector-v2/source/Rds.md:
##########
@@ -0,0 +1,7 @@
+# Rds

Review Comment:
   move to new pull request?



##########
seatunnel-connectors-v2/connector-iceberg/pom.xml:
##########
@@ -120,6 +120,7 @@
         <dependency>
             <groupId>org.apache.flink</groupId>
             <artifactId>flink-shaded-hadoop-2</artifactId>
+            <scope>provided</scope>

Review Comment:
   update docs
   
   https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/connector-v2/source/Iceberg.md



##########
docs/en/connector-v2/sink/Rds.md:
##########
@@ -0,0 +1,7 @@
+# Rds

Review Comment:
   move to new pull request?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org