You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/04/05 13:28:53 UTC
[GitHub] [cordova-ios] jcesarmobile opened a new pull request #822: chore:
remove deprecated orientation methods
jcesarmobile opened a new pull request #822: chore: remove deprecated orientation methods
URL: https://github.com/apache/cordova-ios/pull/822
`- (NSUInteger)application:(UIApplication*)application supportedInterfaceOrientationsForWindow:(UIWindow*)window`, `- (NSUInteger)supportedInterfaceOrientations;` and `- (BOOL)shouldAutorotateToInterfaceOrientation:(UIInterfaceOrientation)interfaceOrientation` were deprecated on iOS 6, remove the code as is not being used.
I think it's not breaking since we have the new methods that replaced them.
closes https://github.com/apache/cordova-ios/issues/821
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io commented on issue #822: chore: remove
deprecated orientation methods
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #822: chore: remove deprecated orientation methods
URL: https://github.com/apache/cordova-ios/pull/822#issuecomment-609426745
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/822?src=pr&el=h1) Report
> Merging [#822](https://codecov.io/gh/apache/cordova-ios/pull/822?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/59b8ac6b12e9e1a91502ffc474400bbf804eea98&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/822?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #822 +/- ##
=======================================
Coverage 74.20% 74.20%
=======================================
Files 13 13
Lines 1849 1849
=======================================
Hits 1372 1372
Misses 477 477
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/822?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/822?src=pr&el=footer). Last update [59b8ac6...fe64afc](https://codecov.io/gh/apache/cordova-ios/pull/822?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-io edited a comment on issue #822: chore:
remove deprecated orientation methods
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #822: chore: remove deprecated orientation methods
URL: https://github.com/apache/cordova-ios/pull/822#issuecomment-609426745
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/822?src=pr&el=h1) Report
> Merging [#822](https://codecov.io/gh/apache/cordova-ios/pull/822?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/59b8ac6b12e9e1a91502ffc474400bbf804eea98&el=desc) will **not change** coverage by `%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-ios/pull/822?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #822 +/- ##
=======================================
Coverage 74.20% 74.20%
=======================================
Files 13 13
Lines 1849 1849
=======================================
Hits 1372 1372
Misses 477 477
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/822?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/822?src=pr&el=footer). Last update [59b8ac6...fe64afc](https://codecov.io/gh/apache/cordova-ios/pull/822?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-ios] jcesarmobile merged pull request #822: chore: remove
deprecated orientation methods
Posted by GitBox <gi...@apache.org>.
jcesarmobile merged pull request #822: chore: remove deprecated orientation methods
URL: https://github.com/apache/cordova-ios/pull/822
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org