You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Bill Havanki <bh...@cloudera.com> on 2013/10/30 15:26:10 UTC
Review Request 15096: ACCUMULO-1829 Add timeout scaling factor to tests
(1.4.x)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15096/
-----------------------------------------------------------
Review request for accumulo.
Bugs: ACCUMULO-1829
https://issues.apache.org/jira/browse/ACCUMULO-1829
Repository: accumulo
Description
-------
Slower hardware or VMs may have trouble completing tests within the timeouts specified. This change adds a -f option to run.py to add a scaling factor to the maxRuntime for tests, the timeout for Accumulo to shut down, and to specific timeouts in SimpleBalancerFairness and ZooCacheTest.
Compare to a similar change for ACCUMULO-1789: https://reviews.apache.org/r/14844/. The additional change to ZooCacheTest is there in place of a fixed timeout increase under 1.5.1-SNAPSHOT.
Diffs
-----
test/system/auto/JavaTest.py f80848c8ef82906cc9f386b1229ee23f6de4a17a
test/system/auto/TestUtils.py 4b5efdf38b1dd6447e5834771f1103b9f7bcca36
test/system/auto/run.py 5a0678bb28ae9a4ecbd44165f9a46d6e5e2bc823
test/system/auto/simple/simpleBalancer.py f77c9c0099a730888de9dfb3dccc56a5cd278afd
test/system/auto/simple/zooCacheTest.py 16b30a6494dbf340dfab7a0cde67114fc96cd7a7
Diff: https://reviews.apache.org/r/15096/diff/
Testing
-------
Ran simple tests on 3-node Accumulo 1.4.3 cluster under CDH 4.3. Some tests fail with no added factor, but all pass with -f 4.
Thanks,
Bill Havanki
Re: Review Request 15096: ACCUMULO-1829 Add timeout scaling factor to tests
(1.4.x)
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15096/#review27924
-----------------------------------------------------------
Ship it!
Ship It!
- Sean Busbey
On Oct. 30, 2013, 2:26 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15096/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 2:26 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1829
> https://issues.apache.org/jira/browse/ACCUMULO-1829
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Slower hardware or VMs may have trouble completing tests within the timeouts specified. This change adds a -f option to run.py to add a scaling factor to the maxRuntime for tests, the timeout for Accumulo to shut down, and to specific timeouts in SimpleBalancerFairness and ZooCacheTest.
>
> Compare to a similar change for ACCUMULO-1789: https://reviews.apache.org/r/14844/. The additional change to ZooCacheTest is there in place of a fixed timeout increase under 1.5.1-SNAPSHOT.
>
>
> Diffs
> -----
>
> test/system/auto/JavaTest.py f80848c8ef82906cc9f386b1229ee23f6de4a17a
> test/system/auto/TestUtils.py 4b5efdf38b1dd6447e5834771f1103b9f7bcca36
> test/system/auto/run.py 5a0678bb28ae9a4ecbd44165f9a46d6e5e2bc823
> test/system/auto/simple/simpleBalancer.py f77c9c0099a730888de9dfb3dccc56a5cd278afd
> test/system/auto/simple/zooCacheTest.py 16b30a6494dbf340dfab7a0cde67114fc96cd7a7
>
> Diff: https://reviews.apache.org/r/15096/diff/
>
>
> Testing
> -------
>
> Ran simple tests on 3-node Accumulo 1.4.3 cluster under CDH 4.3. Some tests fail with no added factor, but all pass with -f 4.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 15096: ACCUMULO-1829 Add timeout scaling factor to tests
(1.4.x)
Posted by Bill Havanki <bh...@cloudera.com>.
> On Oct. 31, 2013, 12:11 p.m., Josh Elser wrote:
> > Looks good to me. One way or the other, lets make sure a README update happens like Sean suggests.
Thanks Josh!
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15096/#review27905
-----------------------------------------------------------
On Oct. 30, 2013, 10:26 a.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15096/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 10:26 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1829
> https://issues.apache.org/jira/browse/ACCUMULO-1829
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Slower hardware or VMs may have trouble completing tests within the timeouts specified. This change adds a -f option to run.py to add a scaling factor to the maxRuntime for tests, the timeout for Accumulo to shut down, and to specific timeouts in SimpleBalancerFairness and ZooCacheTest.
>
> Compare to a similar change for ACCUMULO-1789: https://reviews.apache.org/r/14844/. The additional change to ZooCacheTest is there in place of a fixed timeout increase under 1.5.1-SNAPSHOT.
>
>
> Diffs
> -----
>
> test/system/auto/JavaTest.py f80848c8ef82906cc9f386b1229ee23f6de4a17a
> test/system/auto/TestUtils.py 4b5efdf38b1dd6447e5834771f1103b9f7bcca36
> test/system/auto/run.py 5a0678bb28ae9a4ecbd44165f9a46d6e5e2bc823
> test/system/auto/simple/simpleBalancer.py f77c9c0099a730888de9dfb3dccc56a5cd278afd
> test/system/auto/simple/zooCacheTest.py 16b30a6494dbf340dfab7a0cde67114fc96cd7a7
>
> Diff: https://reviews.apache.org/r/15096/diff/
>
>
> Testing
> -------
>
> Ran simple tests on 3-node Accumulo 1.4.3 cluster under CDH 4.3. Some tests fail with no added factor, but all pass with -f 4.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 15096: ACCUMULO-1829 Add timeout scaling factor to tests
(1.4.x)
Posted by Josh Elser <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15096/#review27905
-----------------------------------------------------------
Ship it!
Looks good to me. One way or the other, lets make sure a README update happens like Sean suggests.
- Josh Elser
On Oct. 30, 2013, 2:26 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15096/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 2:26 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1829
> https://issues.apache.org/jira/browse/ACCUMULO-1829
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Slower hardware or VMs may have trouble completing tests within the timeouts specified. This change adds a -f option to run.py to add a scaling factor to the maxRuntime for tests, the timeout for Accumulo to shut down, and to specific timeouts in SimpleBalancerFairness and ZooCacheTest.
>
> Compare to a similar change for ACCUMULO-1789: https://reviews.apache.org/r/14844/. The additional change to ZooCacheTest is there in place of a fixed timeout increase under 1.5.1-SNAPSHOT.
>
>
> Diffs
> -----
>
> test/system/auto/JavaTest.py f80848c8ef82906cc9f386b1229ee23f6de4a17a
> test/system/auto/TestUtils.py 4b5efdf38b1dd6447e5834771f1103b9f7bcca36
> test/system/auto/run.py 5a0678bb28ae9a4ecbd44165f9a46d6e5e2bc823
> test/system/auto/simple/simpleBalancer.py f77c9c0099a730888de9dfb3dccc56a5cd278afd
> test/system/auto/simple/zooCacheTest.py 16b30a6494dbf340dfab7a0cde67114fc96cd7a7
>
> Diff: https://reviews.apache.org/r/15096/diff/
>
>
> Testing
> -------
>
> Ran simple tests on 3-node Accumulo 1.4.3 cluster under CDH 4.3. Some tests fail with no added factor, but all pass with -f 4.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 15096: ACCUMULO-1829 Add timeout scaling factor to tests
(1.4.x)
Posted by Bill Havanki <bh...@cloudera.com>.
> On Oct. 31, 2013, 11:35 a.m., Sean Busbey wrote:
> > test/system/auto/run.py, line 246
> > <https://reviews.apache.org/r/15096/diff/1/?file=373936#file373936line246>
> >
> > There's no update to the README explaining the additional option (which I realize the original didn't do either).
> >
> > Follow on ticket? or issue here?
I vote follow-on ticket. The -x option isn't updated in the doc either, and adding it for this issue is slightly out-of-scope. A separate ticket will also make porting up to 1.5.x easier.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15096/#review27900
-----------------------------------------------------------
On Oct. 30, 2013, 10:26 a.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15096/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 10:26 a.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1829
> https://issues.apache.org/jira/browse/ACCUMULO-1829
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Slower hardware or VMs may have trouble completing tests within the timeouts specified. This change adds a -f option to run.py to add a scaling factor to the maxRuntime for tests, the timeout for Accumulo to shut down, and to specific timeouts in SimpleBalancerFairness and ZooCacheTest.
>
> Compare to a similar change for ACCUMULO-1789: https://reviews.apache.org/r/14844/. The additional change to ZooCacheTest is there in place of a fixed timeout increase under 1.5.1-SNAPSHOT.
>
>
> Diffs
> -----
>
> test/system/auto/JavaTest.py f80848c8ef82906cc9f386b1229ee23f6de4a17a
> test/system/auto/TestUtils.py 4b5efdf38b1dd6447e5834771f1103b9f7bcca36
> test/system/auto/run.py 5a0678bb28ae9a4ecbd44165f9a46d6e5e2bc823
> test/system/auto/simple/simpleBalancer.py f77c9c0099a730888de9dfb3dccc56a5cd278afd
> test/system/auto/simple/zooCacheTest.py 16b30a6494dbf340dfab7a0cde67114fc96cd7a7
>
> Diff: https://reviews.apache.org/r/15096/diff/
>
>
> Testing
> -------
>
> Ran simple tests on 3-node Accumulo 1.4.3 cluster under CDH 4.3. Some tests fail with no added factor, but all pass with -f 4.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 15096: ACCUMULO-1829 Add timeout scaling factor to tests
(1.4.x)
Posted by Sean Busbey <se...@manvsbeard.com>.
> On Oct. 31, 2013, 3:35 p.m., Sean Busbey wrote:
> > test/system/auto/run.py, line 246
> > <https://reviews.apache.org/r/15096/diff/1/?file=373936#file373936line246>
> >
> > There's no update to the README explaining the additional option (which I realize the original didn't do either).
> >
> > Follow on ticket? or issue here?
>
> Bill Havanki wrote:
> I vote follow-on ticket. The -x option isn't updated in the doc either, and adding it for this issue is slightly out-of-scope. A separate ticket will also make porting up to 1.5.x easier.
Agreed.
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15096/#review27900
-----------------------------------------------------------
On Oct. 30, 2013, 2:26 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15096/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 2:26 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1829
> https://issues.apache.org/jira/browse/ACCUMULO-1829
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Slower hardware or VMs may have trouble completing tests within the timeouts specified. This change adds a -f option to run.py to add a scaling factor to the maxRuntime for tests, the timeout for Accumulo to shut down, and to specific timeouts in SimpleBalancerFairness and ZooCacheTest.
>
> Compare to a similar change for ACCUMULO-1789: https://reviews.apache.org/r/14844/. The additional change to ZooCacheTest is there in place of a fixed timeout increase under 1.5.1-SNAPSHOT.
>
>
> Diffs
> -----
>
> test/system/auto/JavaTest.py f80848c8ef82906cc9f386b1229ee23f6de4a17a
> test/system/auto/TestUtils.py 4b5efdf38b1dd6447e5834771f1103b9f7bcca36
> test/system/auto/run.py 5a0678bb28ae9a4ecbd44165f9a46d6e5e2bc823
> test/system/auto/simple/simpleBalancer.py f77c9c0099a730888de9dfb3dccc56a5cd278afd
> test/system/auto/simple/zooCacheTest.py 16b30a6494dbf340dfab7a0cde67114fc96cd7a7
>
> Diff: https://reviews.apache.org/r/15096/diff/
>
>
> Testing
> -------
>
> Ran simple tests on 3-node Accumulo 1.4.3 cluster under CDH 4.3. Some tests fail with no added factor, but all pass with -f 4.
>
>
> Thanks,
>
> Bill Havanki
>
>
Re: Review Request 15096: ACCUMULO-1829 Add timeout scaling factor to tests
(1.4.x)
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15096/#review27900
-----------------------------------------------------------
test/system/auto/run.py
<https://reviews.apache.org/r/15096/#comment54315>
There's no update to the README explaining the additional option (which I realize the original didn't do either).
Follow on ticket? or issue here?
- Sean Busbey
On Oct. 30, 2013, 2:26 p.m., Bill Havanki wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15096/
> -----------------------------------------------------------
>
> (Updated Oct. 30, 2013, 2:26 p.m.)
>
>
> Review request for accumulo.
>
>
> Bugs: ACCUMULO-1829
> https://issues.apache.org/jira/browse/ACCUMULO-1829
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Slower hardware or VMs may have trouble completing tests within the timeouts specified. This change adds a -f option to run.py to add a scaling factor to the maxRuntime for tests, the timeout for Accumulo to shut down, and to specific timeouts in SimpleBalancerFairness and ZooCacheTest.
>
> Compare to a similar change for ACCUMULO-1789: https://reviews.apache.org/r/14844/. The additional change to ZooCacheTest is there in place of a fixed timeout increase under 1.5.1-SNAPSHOT.
>
>
> Diffs
> -----
>
> test/system/auto/JavaTest.py f80848c8ef82906cc9f386b1229ee23f6de4a17a
> test/system/auto/TestUtils.py 4b5efdf38b1dd6447e5834771f1103b9f7bcca36
> test/system/auto/run.py 5a0678bb28ae9a4ecbd44165f9a46d6e5e2bc823
> test/system/auto/simple/simpleBalancer.py f77c9c0099a730888de9dfb3dccc56a5cd278afd
> test/system/auto/simple/zooCacheTest.py 16b30a6494dbf340dfab7a0cde67114fc96cd7a7
>
> Diff: https://reviews.apache.org/r/15096/diff/
>
>
> Testing
> -------
>
> Ran simple tests on 3-node Accumulo 1.4.3 cluster under CDH 4.3. Some tests fail with no added factor, but all pass with -f 4.
>
>
> Thanks,
>
> Bill Havanki
>
>