[jira] Commented: (HADOOP-4985) IOException is abused in FSDirectory

["Konstantin Shvachko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12662573#action_12662573 ] 

Konstantin Shvachko commented on HADOOP-4985:
---------------------------------------------

- FSDirectory empty line change.
- Javadoc for {{FSDirectory.setReplication()}} should not remove {{@throws IOException}} but rather replace it with {{@throws QuotaExceededException}}
- {{FileNotFoundException("Unknown file: " ...)}} should be {{FileNotFoundException("File does not exist: " ...)}}
I once tried to unify this in the code, but it's now back with all different messages. 
- Additionally we can remove IOException in 
FSEditLog.close()
FSEditLog.existsNew()
FSEditLog.logOpenFile()
FSEditLog.getFsEditName()
and then 
FSDirectory.persistBlocks()
FSDirectory.closeFile()
FSDirectory.setTimes()
and then
FSNamesystem.getBlockLocationsInternal()

> IOException is abused in FSDirectory
> ------------------------------------
>
>                 Key: HADOOP-4985
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4985
>             Project: Hadoop Core
>          Issue Type: Bug
>          Components: dfs
>            Reporter: Tsz Wo (Nicholas), SZE
>         Attachments: 4985_20090106.patch, 4985_20090107.patch
>
>
> In FSDirectory, quite a few methods are unnecessary declared with "throws IOException".  In some cases, it can just be removed without causing any compilation problem.  In some other cases, it can be replaced with a specific subclass like QuotaExceededException.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.