You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/09 16:01:18 UTC

[GitHub] [flink] walterddr opened a new pull request #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate

walterddr opened a new pull request #8389: [FLINK-12399][table] Fix FilterableTableSource does not change after applyPredicate
URL: https://github.com/apache/flink/pull/8389
 
 
   ## What is the purpose of the change
   
   This PR fixes the problem: FilterableTableSource does not generate a new digest after the predicate push down, unless `explainSource()` API is explicitly override. 
   
   ## Brief change log
   
   
     - Changed the `explainTerm` API from `FlinkLogicalTableSourceScan` to include auxiliary source description.
     - Changed the `TestFilterableTableSource` to include both the none explainSource and with explainSource version.
     - Added test to both stream and batch cases.
   
   ## Verifying this change
   
     - Tests for both stream and batch cases for predicate push down without explainSource override.
     - Others are covered for current tests.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? n/a
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services