You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/09/29 20:29:09 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request, #6785: server, api, ui: allow host auto-select for migrateVirtualMachineWith…
shwstppr opened a new pull request, #6785:
URL: https://github.com/apache/cloudstack/pull/6785
### Description
Fixes #6773
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [x] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1264134826
<b>Trillian test result (tid-5059)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 48674 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6785-t5059-kvm-centos7.zip
Smoke tests completed. 100 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_unsecure_vm_migration | `Error` | 225.92 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 145.08 | test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration | `Error` | 153.13 | test_vm_life_cycle.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 605.48 | test_kubernetes_clusters.py
test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | `Failure` | 650.62 | test_vpc_redundant.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#discussion_r1168539271
##########
api/src/main/java/org/apache/cloudstack/api/command/admin/vm/MigrateVirtualMachineWithVolumeCmd.java:
##########
@@ -83,6 +83,12 @@ public class MigrateVirtualMachineWithVolumeCmd extends BaseAsyncCmd {
"<1b331390-59f2-4796-9993-bf11c6e76225>&migrateto[2].pool=<41fdb564-9d3b-447d-88ed-7628f7640cbc>")
private Map migrateVolumeTo;
+ @Parameter(name = ApiConstants.AUTO_SELECT,
+ since = "4.18.0",
Review Comment:
no longer true
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -6751,8 +6737,23 @@ private boolean isImplicitPlannerUsedByOffering(long offeringId) {
return implicitPlannerUsed;
}
- private boolean isVmVolumesOnZoneWideStore(VMInstanceVO vm) {
- final List<VolumeVO> volumes = _volsDao.findCreatedByInstance(vm.getId());
+ private boolean isVmVolumesUsingLocalStorage(final List<VolumeVO> volumes) {
Review Comment:
The code in this method looks exactly like the bit in `isVmVolumesOnZoneWideStore`
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -6751,8 +6737,23 @@ private boolean isImplicitPlannerUsedByOffering(long offeringId) {
return implicitPlannerUsed;
}
- private boolean isVmVolumesOnZoneWideStore(VMInstanceVO vm) {
- final List<VolumeVO> volumes = _volsDao.findCreatedByInstance(vm.getId());
+ private boolean isVmVolumesUsingLocalStorage(final List<VolumeVO> volumes) {
+ if (CollectionUtils.isEmpty(volumes)) {
+ return false;
+ }
+ for (Volume volume : volumes) {
+ if (volume == null || volume.getPoolId() == null) {
+ return false;
+ }
+ StoragePoolVO pool = _storagePoolDao.findById(volume.getPoolId());
+ if (pool == null || !ScopeType.ZONE.equals(pool.getScope())) {
+ return false;
+ }
Review Comment:
should this read something like
```suggestion
if (volume == null || volume.getPoolId() == null) {
return false;
}
StoragePoolVO pool = _storagePoolDao.findById(volume.getPoolId());
if (pool == null || !ScopeType.ZONE.equals(pool.getScope())) {
return false;
}
```
???
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -6952,6 +6958,18 @@ public VirtualMachine migrateVirtualMachineWithVolume(Long vmId, Host destinatio
Map<Long, Long> volToPoolObjectMap = getVolumePoolMappingForMigrateVmWithStorage(vm, volumeToPool);
+ if (destinationHost == null) {
+ Long poolId = null;
+ if (MapUtils.isNotEmpty(volToPoolObjectMap)) {
+ poolId = new ArrayList<>(volToPoolObjectMap.values()).get(0);
+ }
+ DeployDestination deployDestination = chooseVmMigrationDestination(vm, srcHost, poolId);
+ if (deployDestination == null) {
+ throw new CloudRuntimeException("Unable to find suitable destination to migrate VM " + vm.getInstanceName());
+ }
+ destinationHost = deployDestination.getHost();
+ }
Review Comment:
can this be extracted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1295008947
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1559997786
Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr closed pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr closed pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
URL: https://github.com/apache/cloudstack/pull/6785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1262784090
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1262844596
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6785)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6785&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6785&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6785&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6785&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6785&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6785&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6785&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1263362161
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1262781832
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1559943403
@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1262832274
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6785)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6785&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6785&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6785&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=CODE_SMELL) [3 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6785&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6785&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6785&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6785&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6785&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1263099639
@shwstppr a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1263362548
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1262788767
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6785 (SL-JID-2443)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1263099253
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1263123459
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1263384916
@DaanHoogland please note I've not done any sort of testing for this yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1560591971
Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1559192855
@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1560085513
Packaging result [LL]: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6054
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1560625702
@shwstppr a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1560582051
Packaging result [LL]: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_multiplication_x: debian :heavy_check_mark: suse15. SL-JID 6055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1263388370
> @DaanHoogland please note I've not done any sort of testing for this yet
I'll do some when I get around. Do you have any test advice on this? I couldn´t reproduce the issue on 4.17.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1262787292
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6785 (SL-JID-2442)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1262940723
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6785?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6785](https://codecov.io/gh/apache/cloudstack/pull/6785?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4b4404f) into [main](https://codecov.io/gh/apache/cloudstack/commit/2e5588c5ead38246c80a6f46c42272651d25d92a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2e5588c) will **increase** coverage by `0.00%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## main #6785 +/- ##
=========================================
Coverage 10.52% 10.52%
- Complexity 6782 6784 +2
=========================================
Files 2464 2464
Lines 243988 243997 +9
Branches 38185 38188 +3
=========================================
+ Hits 25686 25690 +4
- Misses 215070 215073 +3
- Partials 3232 3234 +2
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../src/main/java/com/cloud/vm/UserVmManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6785/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3ZtL1VzZXJWbU1hbmFnZXJJbXBsLmphdmE=) | `5.58% <0.00%> (-0.02%)` | :arrow_down: |
| [...om/cloud/hypervisor/kvm/resource/LibvirtVMDef.java](https://codecov.io/gh/apache/cloudstack/pull/6785/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydFZNRGVmLmphdmE=) | `64.15% <0.00%> (ø)` | |
| [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/6785/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `28.84% <0.00%> (+7.69%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1560623688
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1566943167
Recreated here https://github.com/apache/cloudstack/pull/7554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1559941967
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1262782388
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1262783228
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1263395521
@DaanHoogland To reproduce, I think one needs to just select Automatically assign in the migrate instance form for a vm that has volumes on local storage,
For tests,
- we will need to test this case which I feel would fail :-D
- test for any regression - user vm migration, systemvm migration, vm storage migration using migrateVirtualMachineWithVolume API and maybe cross-cluster migration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1264942832
> Nice enhancement
Did you test @weizhouapache ? I didn´t get to it yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1559221643
Packaging result [SF]: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: el9 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 6128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6785: api, server, ui: allow host auto-select for migrateVirtualMachineWith…
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #6785:
URL: https://github.com/apache/cloudstack/pull/6785#issuecomment-1559191656
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org