[GitHub] [lucene] jtibshirani commented on a change in pull request #432: LUCENE-10228: Ensure PerFieldKnnVectorsFormat uses right format name

[GitBox <gi...@apache.org>]

jtibshirani commented on a change in pull request #432:
URL: https://github.com/apache/lucene/pull/432#discussion_r746091086



##########
File path: lucene/core/src/java/org/apache/lucene/codecs/perfield/PerFieldKnnVectorsFormat.java
##########
@@ -123,25 +123,17 @@ private KnnVectorsWriter getInstance(FieldInfo field) throws IOException {
       final String formatName = format.getName();
 
       field.putAttribute(PER_FIELD_FORMAT_KEY, formatName);
-      Integer suffix = null;
+      Integer suffix;
 
       WriterAndSuffix writerAndSuffix = formats.get(format);
       if (writerAndSuffix == null) {
         // First time we are seeing this format; create a new instance
 
-        String suffixAtt = field.getAttribute(PER_FIELD_SUFFIX_KEY);

Review comment:
       I think this was accidentally copied over from `PerFieldDocValuesFormat`. The logic there only applies for doc value updates.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org