You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2015/08/30 06:25:06 UTC

Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37929/
-----------------------------------------------------------

Review request for mesos, Jie Yu and Timothy Chen.


Repository: mesos


Description
-------

- i.e., It fetches images transparently when it's not in the local cache.
- This way, the store doesn't have the sense of "localness" anymore but rather it's an abstraction that provides access to all discoverable images, no matter where they can be found.

Some context for motivation of this change can be found at: https://reviews.apache.org/r/37881/


Diffs
-----

  src/slave/containerizer/provisioners/appc/store.hpp e48d91be06410bfc028a7b2ed88218e13adbffee 
  src/slave/containerizer/provisioners/appc/store.cpp fbd1c535d398a4d37c30ba23f5408095c7d35b65 
  src/tests/containerizer/appc_provisioner_tests.cpp 47b66b9c30cefe8f9a8e2c1c1341776c2d235020 

Diff: https://reviews.apache.org/r/37929/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu


Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37929/
-----------------------------------------------------------

(Updated Aug. 29, 2015, 9:25 p.m.)


Review request for mesos, Jie Yu and Timothy Chen.


Repository: mesos


Description
-------

- i.e., It fetches images transparently when it's not in the local cache.
- This way, the store doesn't have the sense of "localness" anymore but rather it's an abstraction that provides access to all discoverable images, no matter where they can be found.

Some context for motivation of this change can be found at: https://reviews.apache.org/r/37881/


Diffs
-----

  src/slave/containerizer/provisioners/appc/store.hpp e48d91be06410bfc028a7b2ed88218e13adbffee 
  src/slave/containerizer/provisioners/appc/store.cpp fbd1c535d398a4d37c30ba23f5408095c7d35b65 
  src/tests/containerizer/appc_provisioner_tests.cpp 47b66b9c30cefe8f9a8e2c1c1341776c2d235020 

Diff: https://reviews.apache.org/r/37929/diff/


Testing
-------

make check.


Thanks,

Jiang Yan Xu