[GitHub] [arrow-datafusion] dadepo commented on a diff in pull request #6593: feat: make_array support empty arguments

["dadepo (via GitHub)" <gi...@apache.org>]

dadepo commented on code in PR #6593:
URL: https://github.com/apache/arrow-datafusion/pull/6593#discussion_r1223876408


##########
datafusion/physical-expr/src/functions.rs:
##########
@@ -404,7 +404,7 @@ pub fn create_physical_fun(
             Arc::new(array_expressions::array_to_string)
         }
         BuiltinScalarFunction::Cardinality => Arc::new(array_expressions::cardinality),
-        BuiltinScalarFunction::MakeArray => Arc::new(array_expressions::array),
+        BuiltinScalarFunction::MakeArray => Arc::new(array_expressions::array_make),

Review Comment:
   Won't `make_array` be a better, more consistent renaming for the function?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org