You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/20 00:46:06 UTC

[GitHub] [incubator-nuttx] yamt commented on a change in pull request #2345: drivers/mtd/mtd_progmem.c: fix progmem_log2 parameter type to match prototype

yamt commented on a change in pull request #2345:
URL: https://github.com/apache/incubator-nuttx/pull/2345#discussion_r527315670



##########
File path: drivers/mtd/mtd_progmem.c
##########
@@ -131,7 +131,7 @@ static struct progmem_dev_s g_progmem =
  *
  ****************************************************************************/
 
-static int32_t progmem_log2(uint32_t blocksize)
+static int32_t progmem_log2(size_t blocksize)

Review comment:
       i guess you should use unsigned long to match https://github.com/apache/incubator-nuttx/blob/23495a7fa26368cde373e7091631de2a1926012b/include/nuttx/mtd/mtd.h#L191




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org