You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by Alykoff <gi...@git.apache.org> on 2018/02/28 08:34:22 UTC
[GitHub] curator pull request #254: Change visible of constructor/fields
GitHub user Alykoff opened a pull request:
https://github.com/apache/curator/pull/254
Change visible of constructor/fields
Change visible for ServiceInstanceBuilder constructor/fields. This is need for extensibility (for example in project https://github.com/hazelcast/hazelcast-zookeeper). I think that package visibility is bad for extensibility. Could you please also say your opinion about change package visibility in others classes?
Current pull request matches with https://github.com/apache/curator/pull/253 and has the issue number.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Alykoff/curator CURATOR-456
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/curator/pull/254.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #254
----
commit 244f1b63ce581a5dd2520184db29f0dbe2f890b7
Author: Gali.Alykov <ga...@...>
Date: 2018-02-28T08:29:46Z
Change visible of constructor/fields
----
---