You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/02/15 09:28:19 UTC
[GitHub] [incubator-doris] HangyuanLiu commented on issue #2910: [PROPOSAL]
Remove unused LLVM related codes
HangyuanLiu commented on issue #2910: [PROPOSAL] Remove unused LLVM related codes
URL: https://github.com/apache/incubator-doris/issues/2910#issuecomment-586571913
+1
I agree with you
Thanks,
Hangyuan Liu
------------------ 原始邮件 ------------------
发件人: "ZHAO Chun"<notifications@github.com>;
发送时间: 2020年2月15日(星期六) 下午4:58
收件人: "apache/incubator-doris"<incubator-doris@noreply.github.com>;
抄送: "Subscribed"<subscribed@noreply.github.com>;
主题: [apache/incubator-doris] [PROPOSAL] Remove unused LLVM related codes (#2910)
At present, there are many LLVM related codes in code base, but these codes are not really used. During my attempt to upgrade GCC, I found that the higher version of GCC is not compatible with the LLVM 3.4.2 version currently used by Doris. I propose to delete all LLVM related code in the code. With this deletion, we can gain the following benefits
Remove irrelevant code to make our code more refined
Ability to upgrade our toolchain from GCC7 to GCC9 or higher
In the future we will be able to use later versions of LLVM. The APIs of the LLVM versions are not compatible, and there is no way to smoothly upgrade to a higher version. And a large amount of code that is no longer used will become a constraint on our future use of higher versions of LLVM.
Since our LLVM code is not really used, this operation will not bring other harm.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org