You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Ruediger Pluem <rp...@apache.org> on 2007/11/21 23:05:05 UTC

Re: svn commit: r597218 - in /apr/apr/trunk: CHANGES build/rpm/apr.spec.in


On 11/21/2007 10:47 PM, minfrin@apache.org wrote:
> Author: minfrin
> Date: Wed Nov 21 13:47:07 2007
> New Revision: 597218
> 
> URL: http://svn.apache.org/viewvc?rev=597218&view=rev
> Log:
> Fix the make test target in the spec file.
> 
> Modified:
>     apr/apr/trunk/CHANGES
>     apr/apr/trunk/build/rpm/apr.spec.in
> 
> Modified: apr/apr/trunk/CHANGES
> URL: http://svn.apache.org/viewvc/apr/apr/trunk/CHANGES?rev=597218&r1=597217&r2=597218&view=diff
> ==============================================================================
> --- apr/apr/trunk/CHANGES [utf-8] (original)
> +++ apr/apr/trunk/CHANGES [utf-8] Wed Nov 21 13:47:07 2007
> @@ -1,6 +1,8 @@
>                                                       -*- coding: utf-8 -*-
>  Changes for APR 1.3.0
>  
> +  *) Fix the make test target in the spec file. [Graham Leggett]
> +
>    *) Add error codes for the SSL EVP interface for apr-util.
>       [Graham Leggett]
>  
> 
> Modified: apr/apr/trunk/build/rpm/apr.spec.in
> URL: http://svn.apache.org/viewvc/apr/apr/trunk/build/rpm/apr.spec.in?rev=597218&r1=597217&r2=597218&view=diff
> ==============================================================================
> --- apr/apr/trunk/build/rpm/apr.spec.in (original)
> +++ apr/apr/trunk/build/rpm/apr.spec.in Wed Nov 21 13:47:07 2007
> @@ -46,7 +46,7 @@
>  %check
>  # Run non-interactive tests
>  pushd test
> -make %{?_smp_mflags} testall CFLAGS=-fno-strict-aliasing
> +make %{?_smp_mflags} all CFLAGS=-fno-strict-aliasing
>  ./testall -v || exit 1
>  popd

Why not running 'make check' from the top level directory?
'make check' calls further testprograms besides testall like
testlockperf and testmutexscope.

Regards

Rüdiger

Re: svn commit: r597218 - in /apr/apr/trunk: CHANGES build/rpm/apr.spec.in

Posted by Graham Leggett <mi...@sharp.fm>.
Ruediger Pluem wrote:

> Why not running 'make check' from the top level directory?
> 'make check' calls further testprograms besides testall like
> testlockperf and testmutexscope.

Just tried to run this:

make
make check
make install

and it is currently mostly stuck running the lock performance tests. I 
suspect the tests were bypassed for speed purposes.

Regards,
Graham
--