You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2023/03/11 15:33:04 UTC

[GitHub] [beam] Abacn commented on pull request #25808: Add periodic.Sequence and periodic.Impulse transforms

Abacn commented on PR #25808:
URL: https://github.com/apache/beam/pull/25808#issuecomment-1464935714

   Thanks for the contribution! This is a very useful transform. For the drain issue, Python and Java implementation also did not drain until recent fix (#23765 #25716). Basically the transform should (i) update watermark when advance and (ii) truncate immediately when truncate is called (happens in drain)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org