You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Peter Royal <pr...@apache.org> on 2003/09/09 15:14:17 UTC
Removing usage of LogKitManager / LogKitManagable
Anyone opposed to removing the usage of the LogKitManagable interface
from HEAD?
The impact is that Loggable components would no longer be able to
receive a logger, and on the flipside, Log4J support will be much
easier to implement as all logging-impl specific code is then in
CocoonServlet, Cocoon.java and all other classes will just deal with
the Avalon facade.
-pete
Re: Removing usage of LogKitManager / LogKitManagable
Posted by Giacomo Pati <gi...@apache.org>.
On Wed, 10 Sep 2003, Antonio Gallardo wrote:
> Peter Royal dijo:
> > On Tuesday, September 9, 2003, at 03:30 PM, Joerg Heinicke wrote:
> >> Ok, done. The vote for the change was unambiguous. Please review my
> >> commits and change the code if necessary.
> >
> > Done. your changes mirrored mine for the most part, and I just layered
> > a few more on top (complete eviction of LogKitManager/able from the
> > codebase) as well as allowing logging in CocoonServlet to be replaces
> > by a subclass (so now a Log4JCocoonServlet should be pretty easy, if
> > someone wants to do it).
>
> Thanks for the nice work. A questions:
>
> 1- Why we does not use log4J as the default logger? AFAIK Log4J is part of
> Apache and still is alive because is better than the included log
> mechanism introduced in J2SDK 1.4.x
> 2- What we can win or lose if we change. I understand the answer"...once
> upon a time.... there was no logger and then there was LogKit......"
You probably missed the recent thread about it. Have a look at
http://marc.theaimsgroup.com/?l=xml-cocoon-users&m=106206358807904&w=2
--
Giacomo Pati
Otego AG, Switzerland - http://www.otego.com
Orixo, the XML business alliance - http://www.orixo.com
Re: Removing usage of LogKitManager / LogKitManagable
Posted by Peter Royal <pr...@apache.org>.
On Wednesday, September 10, 2003, at 05:03 PM, Antonio Gallardo wrote:
> This is a nice story, but can someone that know both (Log4J and LogKit)
> really said what we can win or lose with changing or staying as we are?
Good question. I'm not the person to answer that.. I'm sure if you were
to code up a Log4JCocoonServlet it would get committed, and we could
easily see if the userbase would prefer Log4J to be the default by the
number of people that adopt it.
-pete
Re: Removing usage of LogKitManager / LogKitManagable
Posted by Antonio Gallardo <ag...@agsoftware.dnsalias.com>.
Peter Royal dijo:
> On Tuesday, September 9, 2003, at 03:30 PM, Joerg Heinicke wrote:
>> Ok, done. The vote for the change was unambiguous. Please review my
>> commits and change the code if necessary.
>
> Done. your changes mirrored mine for the most part, and I just layered
> a few more on top (complete eviction of LogKitManager/able from the
> codebase) as well as allowing logging in CocoonServlet to be replaces
> by a subclass (so now a Log4JCocoonServlet should be pretty easy, if
> someone wants to do it).
Thanks for the nice work. A questions:
1- Why we does not use log4J as the default logger? AFAIK Log4J is part of
Apache and still is alive because is better than the included log
mechanism introduced in J2SDK 1.4.x
2- What we can win or lose if we change. I understand the answer"...once
upon a time.... there was no logger and then there was LogKit......"
This is a nice story, but can someone that know both (Log4J and LogKit)
really said what we can win or lose with changing or staying as we are?
Note: I dont want to start a war, this is sincerely questions to think and
choose the best to our loved Cocoon. :)
Best Regards,
Antonio Gallardo.
Re: Removing usage of LogKitManager / LogKitManagable
Posted by Steven Noels <st...@outerthought.org>.
Joerg Heinicke wrote:
> Ok, with this change we should have satisfied Robert Simmons at the end.
A day worthy of remembrance.
Thanks, Peter!
</Steven>
--
Steven Noels http://outerthought.org/
Outerthought - Open Source Java & XML An Orixo Member
Read my weblog at http://blogs.cocoondev.org/stevenn/
stevenn at outerthought.org stevenn at apache.org
Re: Removing usage of LogKitManager / LogKitManagable
Posted by Joerg Heinicke <jh...@virbus.de>.
Peter Royal wrote:
> On Tuesday, September 9, 2003, at 03:30 PM, Joerg Heinicke wrote:
>
>> Ok, done. The vote for the change was unambiguous. Please review my
>> commits and change the code if necessary.
>
> Done. your changes mirrored mine for the most part, and I just layered a
> few more on top (complete eviction of LogKitManager/able from the
> codebase)
Thanks for the work. If I knew it were so easy (simply removing everything
LogKit related), I could have done it too :-) But therefore I simply miss
the inside-view ...
> as well as allowing logging in CocoonServlet to be replaces by
> a subclass (so now a Log4JCocoonServlet should be pretty easy, if
> someone wants to do it)
> -pete
Ok, with this change we should have satisfied Robert Simmons at the end.
Joerg
--
System Development
VIRBUS AG
Fon +49(0)341-979-7419
Fax +49(0)341-979-7409
joerg.heinicke@virbus.de
www.virbus.de
Re: Removing usage of LogKitManager / LogKitManagable
Posted by Peter Royal <pr...@apache.org>.
On Tuesday, September 9, 2003, at 03:30 PM, Joerg Heinicke wrote:
> Ok, done. The vote for the change was unambiguous. Please review my
> commits and change the code if necessary.
Done. your changes mirrored mine for the most part, and I just layered
a few more on top (complete eviction of LogKitManager/able from the
codebase) as well as allowing logging in CocoonServlet to be replaces
by a subclass (so now a Log4JCocoonServlet should be pretty easy, if
someone wants to do it)
-pete
Re: Removing usage of LogKitManager / LogKitManagable
Posted by Joerg Heinicke <jh...@virbus.de>.
Ok, done. The vote for the change was unambiguous. Please review my
commits and change the code if necessary.
Joerg
Peter Royal wrote:
> On Tuesday, September 9, 2003, at 12:34 PM, Joerg Heinicke wrote:
>
>> Hello Peter,
>>
>> we already have this:
>> http://marc.theaimsgroup.com/?l=xml-cocoon-dev&m=106215953707243&w=2
>> and this:
>> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21730.
>>
>> If it's wished I can do the change again and commit it immediately.
>>
>> Anybody against it?
>
>
> That's what I get for not paying attention :)
>
> I say commit it. I also have some slight changes to go on top of that
> when subclassing CocoonServlet to have it connect to an existing Logger
> hierarchy that I'll apply when you're done.
> -pete
Re: Removing usage of LogKitManager / LogKitManagable
Posted by Peter Royal <pr...@apache.org>.
On Tuesday, September 9, 2003, at 12:34 PM, Joerg Heinicke wrote:
> Hello Peter,
>
> we already have this:
> http://marc.theaimsgroup.com/?l=xml-cocoon-dev&m=106215953707243&w=2
> and this:
> http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21730.
>
> If it's wished I can do the change again and commit it immediately.
>
> Anybody against it?
That's what I get for not paying attention :)
I say commit it. I also have some slight changes to go on top of that
when subclassing CocoonServlet to have it connect to an existing Logger
hierarchy that I'll apply when you're done.
-pete
Re: Removing usage of LogKitManager / LogKitManagable
Posted by Joerg Heinicke <jh...@virbus.de>.
Hello Peter,
we already have this:
http://marc.theaimsgroup.com/?l=xml-cocoon-dev&m=106215953707243&w=2
and this:
http://nagoya.apache.org/bugzilla/show_bug.cgi?id=21730.
If it's wished I can do the change again and commit it immediately.
Anybody against it?
Joerg
Peter Royal wrote:
> Anyone opposed to removing the usage of the LogKitManagable interface
> from HEAD?
>
> The impact is that Loggable components would no longer be able to
> receive a logger, and on the flipside, Log4J support will be much easier
> to implement as all logging-impl specific code is then in CocoonServlet,
> Cocoon.java and all other classes will just deal with the Avalon facade.
>
> -pete