[GitHub] janl commented on issue #1153: Flexible replicator client auth + session support

[GitBox <gi...@apache.org>]

janl commented on issue #1153: Flexible replicator client auth + session support
URL: https://github.com/apache/couchdb/issues/1153#issuecomment-364142882
 
 
   I?m very +1 on this. Just a few notes.
   
   Implementation idea: I like the adapter implementation plan.
   
   OAuth 1 : as seems to be consensus here already, nuke to appropriate orbit.
   
   > A list of replicator client authentication handler modules is specified in the config file
   
   I know this is how we?ve done this in the past, and that this makes it relatively easy for Cloudant to customise things, but I think we want to move away from having too many code-level config items. The ini files are unwieldy as is, and we should think about moving this to a separate, source-level config file (like we?ve done for the stats cfg).
   
   ```
   update_headers(#httpdb{}, Headers) -> {ok, UpdatedHeaders} | {error, Error}
   
   handle_response(#httpdb{}, ResponseCode, ResponseMessage) -> ok | retry | {error, Error}
   ```
   
   I?m just wondering about symmetry here, could `update_headers` also be `handle_request`? Just seems more what the intent of this function is, rather than an implementation detail. // imagine an auth format that messes with the body (not that that one should have such a format, bear with me) as well as the headers, that?d be awkward to finagle into this signature. // just a question :)
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services