You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/06/03 15:55:46 UTC
[PR] ci: gate expensive test workflows at the job level [superset]
rusackas opened a new pull request, #40718:
URL: https://github.com/apache/superset/pull/40718
### SUMMARY
The Cypress, Playwright, and Python test workflows ran change-detection at the
**step level**: every matrix runner spun up, checked out the repo, ran the
`change-detector` action, and *then* skipped its individual steps when the
relevant files weren't touched. On a docs-only or otherwise unrelated PR, that
still provisioned all of those runners — 12+ Cypress shards, the 3
integration-test databases, the Presto/Hive jobs, the experimental Playwright
matrix — only to no-op step by step.
This PR adopts the pattern `superset-frontend.yml` already uses: a single
lightweight `changes` job runs the change-detector **once** and exposes its
outputs, and each expensive job gates on it at the **job level**:
```yaml
changes:
outputs:
python: ${{ steps.check.outputs.python }}
frontend: ${{ steps.check.outputs.frontend }}
steps: [checkout, change-detector]
<expensive-job>:
needs: changes
if: needs.changes.outputs.python == 'true' # (|| frontend for e2e/playwright)
```
Jobs that don't apply to a PR are now **skipped outright** instead of
provisioning a runner just to skip every step. The redundant per-job
change-detector step and the per-step `if:` guards are removed.
Workflows touched:
- `superset-e2e.yml` (Cypress + required Playwright)
- `superset-playwright.yml` (experimental Playwright)
- `superset-python-unittest.yml`
- `superset-python-integrationtest.yml` (mysql / postgres / sqlite)
- `superset-python-presto-hive.yml` (presto / hive)
**Behavior preserved:**
- `workflow_dispatch` / `schedule` runs still execute everything — the detector
returns "all changed" for those events, so the gate evaluates true.
- Skipped required jobs are treated as passing by branch protection (same as the
existing `superset-frontend.yml` behavior), so this doesn't block merges.
### TESTING INSTRUCTIONS
- On a code PR: confirm the `changes` job runs and the relevant test jobs run as
before.
- On a docs-only PR: confirm the test jobs are **skipped** (not just no-op'd) and
no Cypress/Python runners are provisioned.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci: gate expensive test workflows at the job level [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas merged PR #40718:
URL: https://github.com/apache/superset/pull/40718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci: gate expensive test workflows at the job level [superset]
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #40718:
URL: https://github.com/apache/superset/pull/40718#discussion_r3350041512
##########
.github/workflows/superset-e2e.yml:
##########
@@ -27,7 +27,28 @@
cancel-in-progress: true
jobs:
+ changes:
+ runs-on: ubuntu-24.04
+ permissions:
+ contents: read
+ pull-requests: read
+ outputs:
+ python: ${{ steps.check.outputs.python }}
+ frontend: ${{ steps.check.outputs.frontend }}
+ steps:
+ - name: Checkout
+ uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
Review Comment:
## zizmor /
action's hash pin has mismatched or missing version comment: points to commit df4cb1c069e1
[Show more details](https://github.com/apache/superset/security/code-scanning/2516)
##########
.github/workflows/superset-python-integrationtest.yml:
##########
@@ -14,7 +14,27 @@
cancel-in-progress: true
jobs:
+ changes:
+ runs-on: ubuntu-24.04
+ permissions:
+ contents: read
+ pull-requests: read
+ outputs:
+ python: ${{ steps.check.outputs.python }}
+ steps:
+ - name: Checkout
+ uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
Review Comment:
## zizmor /
action's hash pin has mismatched or missing version comment: points to commit df4cb1c069e1
[Show more details](https://github.com/apache/superset/security/code-scanning/2518)
##########
.github/workflows/superset-python-unittest.yml:
##########
@@ -15,7 +15,27 @@
cancel-in-progress: true
jobs:
+ changes:
+ runs-on: ubuntu-24.04
+ permissions:
+ contents: read
+ pull-requests: read
+ outputs:
+ python: ${{ steps.check.outputs.python }}
+ steps:
+ - name: Checkout
+ uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
Review Comment:
## zizmor /
action's hash pin has mismatched or missing version comment: points to commit df4cb1c069e1
[Show more details](https://github.com/apache/superset/security/code-scanning/2520)
##########
.github/workflows/superset-playwright.yml:
##########
@@ -23,9 +23,30 @@
cancel-in-progress: true
jobs:
+ changes:
+ runs-on: ubuntu-24.04
+ permissions:
+ contents: read
+ pull-requests: read
+ outputs:
+ python: ${{ steps.check.outputs.python }}
+ frontend: ${{ steps.check.outputs.frontend }}
+ steps:
+ - name: Checkout
+ uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
Review Comment:
## zizmor /
action's hash pin has mismatched or missing version comment: points to commit df4cb1c069e1
[Show more details](https://github.com/apache/superset/security/code-scanning/2517)
##########
.github/workflows/superset-python-presto-hive.yml:
##########
@@ -15,7 +15,27 @@
cancel-in-progress: true
jobs:
+ changes:
+ runs-on: ubuntu-24.04
+ permissions:
+ contents: read
+ pull-requests: read
+ outputs:
+ python: ${{ steps.check.outputs.python }}
+ steps:
+ - name: Checkout
+ uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6
Review Comment:
## zizmor /
action's hash pin has mismatched or missing version comment: points to commit df4cb1c069e1
[Show more details](https://github.com/apache/superset/security/code-scanning/2519)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci: gate expensive test workflows at the job level [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40718:
URL: https://github.com/apache/superset/pull/40718#issuecomment-4614503749
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/40718?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 63.49%. Comparing base ([`cb2a56d`](https://app.codecov.io/gh/apache/superset/commit/cb2a56d16e0bccf0e6d8cb878b90ca3474b1a7b4?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`bdf44eb`](https://app.codecov.io/gh/apache/superset/commit/bdf44eb41480218bdc889a94e05fc84bc7d06c85?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40718 +/- ##
==========================================
- Coverage 64.07% 63.49% -0.59%
==========================================
Files 2663 2663
Lines 143505 143505
Branches 32993 32993
==========================================
- Hits 91951 91118 -833
- Misses 49952 50785 +833
Partials 1602 1602
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/40718/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/40718/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.72% <ø> (ø)` | |
| [javascript](https://app.codecov.io/gh/apache/superset/pull/40718/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `67.57% <ø> (ø)` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/40718/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.46% <ø> (ø)` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/40718/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.54% <ø> (ø)` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/40718/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.31% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/40718/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.76% <ø> (-1.25%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/40718/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.16% <ø> (ø)` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/40718/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/40718?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] ci: gate expensive test workflows at the job level [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40718:
URL: https://github.com/apache/superset/pull/40718#issuecomment-4614291181
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org