You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by tfitschen <gi...@git.apache.org> on 2015/05/28 11:45:47 UTC
[GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...
GitHub user tfitschen opened a pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/48
CB-8396 - Read property "AutoHideSplashScreen" on android
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mayflower/cordova-plugin-splashscreen CB-8396-auto-hide-on-android
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-splashscreen/pull/48.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #48
----
commit 2a34454ca8deed502d45616d771a9953baaa81de
Author: Torben Fitschen <to...@mayflower.de>
Date: 2015-05-28T09:43:39Z
Read property "AutoHideSplashScreen" on android
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...
Posted by kentmw <gi...@git.apache.org>.
Github user kentmw commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/48#issuecomment-149990798
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...
Posted by sencenan <gi...@git.apache.org>.
Github user sencenan commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/48#issuecomment-153207385
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...
Posted by tfitschen <gi...@git.apache.org>.
Github user tfitschen closed the pull request at:
https://github.com/apache/cordova-plugin-splashscreen/pull/48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...
Posted by miqmago <gi...@git.apache.org>.
Github user miqmago commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/48#issuecomment-106736212
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...
Posted by agrieve <gi...@git.apache.org>.
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/48#discussion_r31235221
--- Diff: src/android/SplashScreen.java ---
@@ -91,7 +91,9 @@ protected void pluginInitialize() {
firstShow = false;
loadSpinner();
- showSplashScreen(true);
+
+ boolean hideAfterDelay = preferences.getBoolean("AutoHideSplashScreen", true);
--- End diff --
The AutoHide preference is meant to hide without the use of a timer (e.g. hide on first paint after onload). Would be happy to accept a PR for this, but I don't think we should have a PR that just turns it off. For this, set a very large timeout.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/48#issuecomment-172761068
@tfitschen, thanks for your contribution!
This has been included into #74, could you please close the PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...
Posted by kentmw <gi...@git.apache.org>.
Github user kentmw commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/48#issuecomment-149993662
Good question, I haven't been able to test this. But it seems crazy that AutoHideSplashScreen isn't being read currently on the android side. Is someone able to test this patch? It also has conflicts.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-splashscreen pull request: CB-8396 - Read property ...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/48#issuecomment-149992603
Does this actually work if you have a signficantly large application loading in the background? Or is this going to cause more white flashes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org