You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Enis Soztutar (JIRA)" <ji...@apache.org> on 2008/04/08 18:11:28 UTC
[jira] Created: (HADOOP-3208) WritableDeserializer does not pass
the Configuration to deserialized Writables
WritableDeserializer does not pass the Configuration to deserialized Writables
------------------------------------------------------------------------------
Key: HADOOP-3208
URL: https://issues.apache.org/jira/browse/HADOOP-3208
Project: Hadoop Core
Issue Type: Bug
Affects Versions: 0.17.0
Reporter: Enis Soztutar
Assignee: Enis Soztutar
Fix For: 0.17.0
{{WritableDeserializer}} does not hold a reference to the Configuration object, so it does not pass it to deserialized writables, but uses ReflectionUtils.newInstance(writableClass, null), which results in objects defining Configurable interface to be initialized with null configuration.
Serialization framework have been introduced in 0.17, so this bug affects 0.17.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3208) WritableDeserializer does not pass
the Configuration to deserialized Writables
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-3208:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Enis
> WritableDeserializer does not pass the Configuration to deserialized Writables
> ------------------------------------------------------------------------------
>
> Key: HADOOP-3208
> URL: https://issues.apache.org/jira/browse/HADOOP-3208
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.17.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: writableDeserializer_v1.patch, writableDeserializer_v2.patch
>
>
> {{WritableDeserializer}} does not hold a reference to the Configuration object, so it does not pass it to deserialized writables, but uses ReflectionUtils.newInstance(writableClass, null), which results in objects defining Configurable interface to be initialized with null configuration.
> Serialization framework have been introduced in 0.17, so this bug affects 0.17.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3208) WritableDeserializer does not pass
the Configuration to deserialized Writables
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587479#action_12587479 ]
Hadoop QA commented on HADOOP-3208:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12379711/writableDeserializer_v2.patch
against trunk revision 645773.
@author +1. The patch does not contain any @author tags.
tests included +1. The patch appears to include 6 new or modified tests.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new javac compiler warnings.
release audit +1. The applied patch does not generate any new release audit warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests +1. The patch passed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2194/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2194/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2194/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch/2194/console
This message is automatically generated.
> WritableDeserializer does not pass the Configuration to deserialized Writables
> ------------------------------------------------------------------------------
>
> Key: HADOOP-3208
> URL: https://issues.apache.org/jira/browse/HADOOP-3208
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.17.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: writableDeserializer_v1.patch, writableDeserializer_v2.patch
>
>
> {{WritableDeserializer}} does not hold a reference to the Configuration object, so it does not pass it to deserialized writables, but uses ReflectionUtils.newInstance(writableClass, null), which results in objects defining Configurable interface to be initialized with null configuration.
> Serialization framework have been introduced in 0.17, so this bug affects 0.17.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3208) WritableDeserializer does not pass
the Configuration to deserialized Writables
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-3208:
----------------------------------
Attachment: writableDeserializer_v1.patch
Patch changes {{WritableSerialization}} and {{WritableDeserializer}} to extend {{Configured}}, so that the configuration is passed.
> WritableDeserializer does not pass the Configuration to deserialized Writables
> ------------------------------------------------------------------------------
>
> Key: HADOOP-3208
> URL: https://issues.apache.org/jira/browse/HADOOP-3208
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.17.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.17.0
>
> Attachments: writableDeserializer_v1.patch
>
>
> {{WritableDeserializer}} does not hold a reference to the Configuration object, so it does not pass it to deserialized writables, but uses ReflectionUtils.newInstance(writableClass, null), which results in objects defining Configurable interface to be initialized with null configuration.
> Serialization framework have been introduced in 0.17, so this bug affects 0.17.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3208) WritableDeserializer does not pass
the Configuration to deserialized Writables
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12587616#action_12587616 ]
Hudson commented on HADOOP-3208:
--------------------------------
Integrated in Hadoop-trunk #456 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/456/])
> WritableDeserializer does not pass the Configuration to deserialized Writables
> ------------------------------------------------------------------------------
>
> Key: HADOOP-3208
> URL: https://issues.apache.org/jira/browse/HADOOP-3208
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.17.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: writableDeserializer_v1.patch, writableDeserializer_v2.patch
>
>
> {{WritableDeserializer}} does not hold a reference to the Configuration object, so it does not pass it to deserialized writables, but uses ReflectionUtils.newInstance(writableClass, null), which results in objects defining Configurable interface to be initialized with null configuration.
> Serialization framework have been introduced in 0.17, so this bug affects 0.17.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3208) WritableDeserializer does not pass
the Configuration to deserialized Writables
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-3208:
----------------------------------
Priority: Blocker (was: Major)
> WritableDeserializer does not pass the Configuration to deserialized Writables
> ------------------------------------------------------------------------------
>
> Key: HADOOP-3208
> URL: https://issues.apache.org/jira/browse/HADOOP-3208
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.17.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Priority: Blocker
> Fix For: 0.17.0
>
> Attachments: writableDeserializer_v1.patch, writableDeserializer_v2.patch
>
>
> {{WritableDeserializer}} does not hold a reference to the Configuration object, so it does not pass it to deserialized writables, but uses ReflectionUtils.newInstance(writableClass, null), which results in objects defining Configurable interface to be initialized with null configuration.
> Serialization framework have been introduced in 0.17, so this bug affects 0.17.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3208) WritableDeserializer does not pass
the Configuration to deserialized Writables
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586937#action_12586937 ]
Doug Cutting commented on HADOOP-3208:
--------------------------------------
The patch looks good to me. Can you please add a test case?
Should this be a blocker? It could break Configurable Writable implementations that depend on a non-null configuration.
> WritableDeserializer does not pass the Configuration to deserialized Writables
> ------------------------------------------------------------------------------
>
> Key: HADOOP-3208
> URL: https://issues.apache.org/jira/browse/HADOOP-3208
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.17.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.17.0
>
> Attachments: writableDeserializer_v1.patch
>
>
> {{WritableDeserializer}} does not hold a reference to the Configuration object, so it does not pass it to deserialized writables, but uses ReflectionUtils.newInstance(writableClass, null), which results in objects defining Configurable interface to be initialized with null configuration.
> Serialization framework have been introduced in 0.17, so this bug affects 0.17.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3208) WritableDeserializer does not pass
the Configuration to deserialized Writables
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-3208:
----------------------------------
Status: Patch Available (was: Open)
> WritableDeserializer does not pass the Configuration to deserialized Writables
> ------------------------------------------------------------------------------
>
> Key: HADOOP-3208
> URL: https://issues.apache.org/jira/browse/HADOOP-3208
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.17.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.17.0
>
> Attachments: writableDeserializer_v1.patch
>
>
> {{WritableDeserializer}} does not hold a reference to the Configuration object, so it does not pass it to deserialized writables, but uses ReflectionUtils.newInstance(writableClass, null), which results in objects defining Configurable interface to be initialized with null configuration.
> Serialization framework have been introduced in 0.17, so this bug affects 0.17.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-3208) WritableDeserializer does not pass
the Configuration to deserialized Writables
Posted by "Enis Soztutar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Enis Soztutar updated HADOOP-3208:
----------------------------------
Attachment: writableDeserializer_v2.patch
This version fixes line wrapping, and introduces a test case.
I forgot to mark this issue a blocker but I think it clearly is.
> WritableDeserializer does not pass the Configuration to deserialized Writables
> ------------------------------------------------------------------------------
>
> Key: HADOOP-3208
> URL: https://issues.apache.org/jira/browse/HADOOP-3208
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.17.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.17.0
>
> Attachments: writableDeserializer_v1.patch, writableDeserializer_v2.patch
>
>
> {{WritableDeserializer}} does not hold a reference to the Configuration object, so it does not pass it to deserialized writables, but uses ReflectionUtils.newInstance(writableClass, null), which results in objects defining Configurable interface to be initialized with null configuration.
> Serialization framework have been introduced in 0.17, so this bug affects 0.17.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3208) WritableDeserializer does not pass
the Configuration to deserialized Writables
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586935#action_12586935 ]
Tom White commented on HADOOP-3208:
-----------------------------------
+1
The patch introduces some lines that are over 80 characters long.
> WritableDeserializer does not pass the Configuration to deserialized Writables
> ------------------------------------------------------------------------------
>
> Key: HADOOP-3208
> URL: https://issues.apache.org/jira/browse/HADOOP-3208
> Project: Hadoop Core
> Issue Type: Bug
> Affects Versions: 0.17.0
> Reporter: Enis Soztutar
> Assignee: Enis Soztutar
> Fix For: 0.17.0
>
> Attachments: writableDeserializer_v1.patch
>
>
> {{WritableDeserializer}} does not hold a reference to the Configuration object, so it does not pass it to deserialized writables, but uses ReflectionUtils.newInstance(writableClass, null), which results in objects defining Configurable interface to be initialized with null configuration.
> Serialization framework have been introduced in 0.17, so this bug affects 0.17.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.