You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Bisk1 (via GitHub)" <gi...@apache.org> on 2023/10/13 21:05:49 UTC
[PR] Fixes #34816 [airflow]
Bisk1 opened a new pull request, #34931:
URL: https://github.com/apache/airflow/pull/34931
Change the order of operations so that async child thread is created after forking when entering daemon context.
This makes sure that the thread stays alive in the internal loop.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix triggerer thread crash in daemon mode [airflow]
Posted by "Bisk1 (via GitHub)" <gi...@apache.org>.
Bisk1 commented on PR #34931:
URL: https://github.com/apache/airflow/pull/34931#issuecomment-1762235540
Also as explained in https://github.com/apache/airflow/issues/34816#issuecomment-1762156063, I'm willing to follow up with another contribution where all other commands are refactored to use the same pattern for daemon mode (and maybe reuse the same code?) but it needs a longer thought so I think it deserves a separate PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix triggerer thread crash in daemon mode [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #34931:
URL: https://github.com/apache/airflow/pull/34931
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix triggerer thread crash in daemon mode [airflow]
Posted by "Bisk1 (via GitHub)" <gi...@apache.org>.
Bisk1 commented on PR #34931:
URL: https://github.com/apache/airflow/pull/34931#issuecomment-1762329207
> Interesting! I believe this would fix the issue.
>
> Could you fix the static checks? https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst
@huss
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org