You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/11/14 09:45:16 UTC
[GitHub] [pulsar] MaiCw4J opened a new pull request #8566: always remove message data size
MaiCw4J opened a new pull request #8566:
URL: https://github.com/apache/pulsar/pull/8566
Signed-off-by: mak <61...@qq.com>
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
always remove message data size when message get out of the queue
may cause the `batchReceive()` method to call `hasEnoughMessagesForBatchReceive()` to determine that the conditions are met, but there is not actually enough data in the queue!
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MaiCw4J commented on pull request #8566: always remove message data size
Posted by GitBox <gi...@apache.org>.
MaiCw4J commented on pull request #8566:
URL: https://github.com/apache/pulsar/pull/8566#issuecomment-749606405
this is not my actual problem, I found out when I was reading the source code :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8566: always remove message data size
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8566:
URL: https://github.com/apache/pulsar/pull/8566#issuecomment-786360434
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MaiCw4J commented on pull request #8566: always remove message data size
Posted by GitBox <gi...@apache.org>.
MaiCw4J commented on pull request #8566:
URL: https://github.com/apache/pulsar/pull/8566#issuecomment-730241620
of course, I would love to do this, but I don't know how to simulate this kind of case, can you give me some help or advise?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on pull request #8566: always remove message data size
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #8566:
URL: https://github.com/apache/pulsar/pull/8566#issuecomment-735525502
@MaiCw4J You mentioned the following in the description of this pull request.
```
may cause the batchReceive() method to call hasEnoughMessagesForBatchReceive() to determine that the conditions are met, but there is not actually enough data in the queue!
```
Can you write a unit test to reproduce the issue you described in using batchReceive? Then you can confirm if this change fixes the issue or not.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap merged pull request #8566: always remove message data size
Posted by GitBox <gi...@apache.org>.
zymap merged pull request #8566:
URL: https://github.com/apache/pulsar/pull/8566
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8566: always remove message data size
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8566:
URL: https://github.com/apache/pulsar/pull/8566#issuecomment-784181713
@MaiCw4J Could you please rebase the code? I want to merge it and make it release in the 2.7.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zymap commented on pull request #8566: always remove message data size
Posted by GitBox <gi...@apache.org>.
zymap commented on pull request #8566:
URL: https://github.com/apache/pulsar/pull/8566#issuecomment-786306875
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org