You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Abhishek Kadam <ab...@gmail.com> on 2018/06/13 05:53:11 UTC
Review Request 67566: ATLAS-2754: UI - Atlas front end fail to show
the input and output entity
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67566/
-----------------------------------------------------------
Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
Bugs: ATLAS-2754
https://issues.apache.org/jira/browse/ATLAS-2754
Repository: atlas
Description
-------
Altas front end fail to show the entity. The server side can return the correct json information for the altas record. but it does not show in the front page.
Diffs
-----
dashboardv2/public/js/utils/CommonViewFunction.js 3d39eb8
Diff: https://reviews.apache.org/r/67566/diff/1/
Testing
-------
Sanity testing done for input and output object.
Thanks,
Abhishek Kadam
Re: Review Request 67566: ATLAS-2754: UI - Atlas front end fail to
show the input and output entity
Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67566/#review204678
-----------------------------------------------------------
Ship it!
Ship It!
- Nixon Rodrigues
On June 13, 2018, 6:36 a.m., Abhishek Kadam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67566/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 6:36 a.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2754
> https://issues.apache.org/jira/browse/ATLAS-2754
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Altas front end fail to show the entity. The server side can return the correct json information for the altas record. but it does not show in the front page.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/utils/CommonViewFunction.js 3d39eb8
>
>
> Diff: https://reviews.apache.org/r/67566/diff/2/
>
>
> Testing
> -------
>
> Sanity testing done for input and output object.
>
>
> Thanks,
>
> Abhishek Kadam
>
>
Re: Review Request 67566: ATLAS-2754: UI - Atlas front end fail to
show the input and output entity
Posted by keval bhatt <kb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67566/#review204675
-----------------------------------------------------------
Ship it!
Ship It!
- keval bhatt
On June 13, 2018, 6:36 a.m., Abhishek Kadam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67566/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 6:36 a.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2754
> https://issues.apache.org/jira/browse/ATLAS-2754
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Altas front end fail to show the entity. The server side can return the correct json information for the altas record. but it does not show in the front page.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/utils/CommonViewFunction.js 3d39eb8
>
>
> Diff: https://reviews.apache.org/r/67566/diff/2/
>
>
> Testing
> -------
>
> Sanity testing done for input and output object.
>
>
> Thanks,
>
> Abhishek Kadam
>
>
Re: Review Request 67566: ATLAS-2754: UI - Atlas front end fail to
show the input and output entity
Posted by Abhishek Kadam <ab...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67566/
-----------------------------------------------------------
(Updated June 13, 2018, 6:36 a.m.)
Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
Changes
-------
This patch address review comment for null check
Bugs: ATLAS-2754
https://issues.apache.org/jira/browse/ATLAS-2754
Repository: atlas
Description
-------
Altas front end fail to show the entity. The server side can return the correct json information for the altas record. but it does not show in the front page.
Diffs (updated)
-----
dashboardv2/public/js/utils/CommonViewFunction.js 3d39eb8
Diff: https://reviews.apache.org/r/67566/diff/2/
Changes: https://reviews.apache.org/r/67566/diff/1-2/
Testing
-------
Sanity testing done for input and output object.
Thanks,
Abhishek Kadam
Re: Review Request 67566: ATLAS-2754: UI - Atlas front end fail to
show the input and output entity
Posted by keval bhatt <kb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67566/#review204662
-----------------------------------------------------------
dashboardv2/public/js/utils/CommonViewFunction.js
Lines 181 (patched)
<https://reviews.apache.org/r/67566/#comment287256>
can you add null check before using attrVal properties
- keval bhatt
On June 13, 2018, 5:53 a.m., Abhishek Kadam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67566/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 5:53 a.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-2754
> https://issues.apache.org/jira/browse/ATLAS-2754
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Altas front end fail to show the entity. The server side can return the correct json information for the altas record. but it does not show in the front page.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/utils/CommonViewFunction.js 3d39eb8
>
>
> Diff: https://reviews.apache.org/r/67566/diff/1/
>
>
> Testing
> -------
>
> Sanity testing done for input and output object.
>
>
> Thanks,
>
> Abhishek Kadam
>
>