[GitHub] [incubator-seatunnel] zhilinli123 commented on a diff in pull request #4524: [Improve][connector][kafka] Set default value for partition option

["zhilinli123 (via GitHub)" <gi...@apache.org>]

zhilinli123 commented on code in PR #4524:
URL: https://github.com/apache/incubator-seatunnel/pull/4524#discussion_r1161684849


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/sink/KafkaSinkFactory.java:
##########
@@ -50,7 +50,6 @@ public OptionRule optionRule() {
                         Config.ASSIGN_PARTITIONS,
                         Config.TRANSACTION_PREFIX,
                         Config.SEMANTICS)
-                .exclusive(Config.PARTITION, Config.PARTITION_KEY_FIELDS)

Review Comment:
   This is a mandatory user configuration, and some users don't really need to configure it
   
   @hailin0 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org