You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Stephen O'Donnell (Jira)" <ji...@apache.org> on 2019/12/17 18:12:00 UTC
[jira] [Commented] (HDDS-2673) Merge MockNodeManager and
SimpleMockNodeManager
[ https://issues.apache.org/jira/browse/HDDS-2673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16998450#comment-16998450 ]
Stephen O'Donnell commented on HDDS-2673:
-----------------------------------------
In SimpleMockNodeManager.getNodeStatus(), if the node is not registered it returns a status indicating the node is healthy and in_service. As part of merging the mock node managers we should look at making the method throw NodeNotFoundException if the node is not registered, but this will require refactoring some tests in TestReplicationManager.
> Merge MockNodeManager and SimpleMockNodeManager
> -----------------------------------------------
>
> Key: HDDS-2673
> URL: https://issues.apache.org/jira/browse/HDDS-2673
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: SCM
> Affects Versions: 0.5.0
> Reporter: Stephen O'Donnell
> Assignee: Stephen O'Donnell
> Priority: Major
>
> MockNodeManager does not fully support the Decommission and Maintenance states currently. To allow the decommission work to progress, SimpleMockNodeManager was created, implementing just enough functionality for decommission / maintenance related tests.
> We should consider making any necessary refactors to MockNodeManager and merge / remove SimpleMockNodeManager.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org