[GitHub] [maven-surefire] slawekjaranowski commented on a diff in pull request #613: [SUREFIRE-2149] Make all ITs run with Maven 3.9.0

["slawekjaranowski (via GitHub)" <gi...@apache.org>]

slawekjaranowski commented on code in PR #613:
URL: https://github.com/apache/maven-surefire/pull/613#discussion_r1103901677


##########
surefire-its/src/test/resources/unicode-testnames/pom.xml:
##########
@@ -51,6 +51,15 @@
         <artifactId>maven-surefire-plugin</artifactId>
         <version>${surefire.version}</version>
       </plugin>
+      <plugin>
+        <groupId>org.apache.maven.plugins</groupId>
+        <artifactId>maven-compiler-plugin</artifactId>
+        <version>3.8.1</version>
+        <!-- Version pinned because version 3.9.0 and higher of the maven-compiler-plugin throw an -->
+        <!-- UnmappableCharacterException when trying to compile the tests in this project -->
+        <!-- This happens only on Windows and only if the Java version is 8 - 17. Not with JDK 19. -->
+        <!-- Further investigation needed to find the cause and a proper fix. -->

Review Comment:
   Should be reported for m-compiler-p in order to be not forgotten



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org