You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openjpa.apache.org by Donald Woods <dw...@apache.org> on 2009/02/11 14:38:28 UTC

Re: svn commit: r743270 - /openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java

Thought this was supposed to be part of my OPENJPA-878 for the Spec 
3.6.4 feature?

Are you in the process of implementing all of the QueryHint support?


-Donald


ppoddar@apache.org wrote:
> Author: ppoddar
> Date: Wed Feb 11 08:12:37 2009
> New Revision: 743270
> 
> URL: http://svn.apache.org/viewvc?rev=743270&view=rev
> Log:
> OPENJPA-898: Parse query hints for NamedNativeQuery
> 
> Modified:
>     openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java
> 
> Modified: openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java
> URL: http://svn.apache.org/viewvc/openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java?rev=743270&r1=743269&r2=743270&view=diff
> ==============================================================================
> --- openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java (original)
> +++ openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java Wed Feb 11 08:12:37 2009
> @@ -1721,6 +1721,8 @@
>  
>              if (!StringUtils.isEmpty(query.resultSetMapping()))
>                  meta.setResultSetMappingName(query.resultSetMapping());
> +            for (QueryHint hint : query.hints())
> +                meta.addHint(hint.name(), hint.value());
>  
>              meta.setSource(getSourceFile(), (el instanceof Class) ? el : null,
>                  meta.SRC_ANNOTATIONS);
> 
> 
> 

Re: svn commit: r743270 - /openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java

Posted by Pinaki Poddar <pp...@apache.org>.
Hi Donald,
  This check-in is about a reported bug that QueryHints annotations not
being parsed within NamedNativeQuery. It is not related to OPENJPA-878.


Donald Woods wrote:
> 
> Thought this was supposed to be part of my OPENJPA-878 for the Spec 
> 3.6.4 feature?
> 
> Are you in the process of implementing all of the QueryHint support?
> 
> 
> -Donald
> 
> 
> ppoddar@apache.org wrote:
>> Author: ppoddar
>> Date: Wed Feb 11 08:12:37 2009
>> New Revision: 743270
>> 
>> URL: http://svn.apache.org/viewvc?rev=743270&view=rev
>> Log:
>> OPENJPA-898: Parse query hints for NamedNativeQuery
>> 
>> Modified:
>>    
>> openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java
>> 
>> Modified:
>> openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java
>> URL:
>> http://svn.apache.org/viewvc/openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java?rev=743270&r1=743269&r2=743270&view=diff
>> ==============================================================================
>> ---
>> openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java
>> (original)
>> +++
>> openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java
>> Wed Feb 11 08:12:37 2009
>> @@ -1721,6 +1721,8 @@
>>  
>>              if (!StringUtils.isEmpty(query.resultSetMapping()))
>>                  meta.setResultSetMappingName(query.resultSetMapping());
>> +            for (QueryHint hint : query.hints())
>> +                meta.addHint(hint.name(), hint.value());
>>  
>>              meta.setSource(getSourceFile(), (el instanceof Class) ? el :
>> null,
>>                  meta.SRC_ANNOTATIONS);
>> 
>> 
>> 
> 
> 

-- 
View this message in context: http://n2.nabble.com/Re%3A-svn-commit%3A-r743270----openjpa-trunk-openjpa-persistence-src-main-java-org-apache-openjpa-persistence-AnnotationPersistenceMetaDataParser.java-tp2308668p2309101.html
Sent from the OpenJPA Developers mailing list archive at Nabble.com.


Re: svn commit: r743270 - /openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java

Posted by Donald Woods <dw...@apache.org>.
Sorry, thought this was an update as part of 899, but no I noticed it 
was a user bug.

BTW - is this going into 12x (which Geronimo will pickup) and 13x?


-Donald


Donald Woods wrote:
> Thought this was supposed to be part of my OPENJPA-878 for the Spec 
> 3.6.4 feature?
> 
> Are you in the process of implementing all of the QueryHint support?
> 
> 
> -Donald
> 
> 
> ppoddar@apache.org wrote:
>> Author: ppoddar
>> Date: Wed Feb 11 08:12:37 2009
>> New Revision: 743270
>>
>> URL: http://svn.apache.org/viewvc?rev=743270&view=rev
>> Log:
>> OPENJPA-898: Parse query hints for NamedNativeQuery
>>
>> Modified:
>>     
>> openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java 
>>
>>
>> Modified: 
>> openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java 
>>
>> URL: 
>> http://svn.apache.org/viewvc/openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java?rev=743270&r1=743269&r2=743270&view=diff 
>>
>> ============================================================================== 
>>
>> --- 
>> openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java 
>> (original)
>> +++ 
>> openjpa/trunk/openjpa-persistence/src/main/java/org/apache/openjpa/persistence/AnnotationPersistenceMetaDataParser.java 
>> Wed Feb 11 08:12:37 2009
>> @@ -1721,6 +1721,8 @@
>>  
>>              if (!StringUtils.isEmpty(query.resultSetMapping()))
>>                  meta.setResultSetMappingName(query.resultSetMapping());
>> +            for (QueryHint hint : query.hints())
>> +                meta.addHint(hint.name(), hint.value());
>>  
>>              meta.setSource(getSourceFile(), (el instanceof Class) ? 
>> el : null,
>>                  meta.SRC_ANNOTATIONS);
>>
>>
>>
>