You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jedcunningham (via GitHub)" <gi...@apache.org> on 2023/06/15 15:23:40 UTC

[GitHub] [airflow] jedcunningham commented on a diff in pull request #31757: feat(jobs/triggerer_job_runner): add triggerer canceled log

jedcunningham commented on code in PR #31757:
URL: https://github.com/apache/airflow/pull/31757#discussion_r1231187333


##########
tests/jobs/test_triggerer_job.py:
##########
@@ -586,3 +613,9 @@ def non_pytest_handlers(val):
     assert qh.__class__ == LocalQueueHandler
     assert qh.queue == listener.queue
     listener.stop()
+    listener = setup_queue_listener()
+    assert handler not in non_pytest_handlers(log.handlers)
+    qh = log.handlers[-1]
+    assert qh.__class__ == LocalQueueHandler
+    assert qh.queue == listener.queue
+    listener.stop()

Review Comment:
   I suspect duplicating these lines wasn't intentional, yeah?
   
   ```suggestion
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org