You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/04/10 14:58:58 UTC
Review Request 33077: Set default cardinality for ComponentInfo if not
specified in metainfo.xml
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33077/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
Bugs: AMBARI-10435
https://issues.apache.org/jira/browse/AMBARI-10435
Repository: ambari
Description
-------
No cardinality specified in metainfo.xml for HCAT component. Possibly for some another components either.
It's better to set cardinallity to some default value like "0+" insteand of null, which could lead to NPE
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 624227e
Diff: https://reviews.apache.org/r/33077/diff/
Testing
-------
unit tests passed
Thanks,
Dmytro Sen
Re: Review Request 33077: Set default cardinality for ComponentInfo
if not specified in metainfo.xml
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33077/#review79676
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On April 10, 2015, 12:58 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33077/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 12:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-10435
> https://issues.apache.org/jira/browse/AMBARI-10435
>
>
> Repository: ambari
>
>
> Description
> -------
>
> No cardinality specified in metainfo.xml for HCAT component. Possibly for some another components either.
> It's better to set cardinallity to some default value like "0+" insteand of null, which could lead to NPE
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 624227e
>
> Diff: https://reviews.apache.org/r/33077/diff/
>
>
> Testing
> -------
>
> unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 33077: Set default cardinality for ComponentInfo
if not specified in metainfo.xml
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33077/#review79723
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 10, 2015, 12:58 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33077/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 12:58 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-10435
> https://issues.apache.org/jira/browse/AMBARI-10435
>
>
> Repository: ambari
>
>
> Description
> -------
>
> No cardinality specified in metainfo.xml for HCAT component. Possibly for some another components either.
> It's better to set cardinallity to some default value like "0+" insteand of null, which could lead to NPE
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 624227e
>
> Diff: https://reviews.apache.org/r/33077/diff/
>
>
> Testing
> -------
>
> unit tests passed
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 33077: Set default cardinality for ComponentInfo
if not specified in metainfo.xml
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33077/
-----------------------------------------------------------
(Updated Апрель 10, 2015, 9:44 п.п.)
Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
Bugs: AMBARI-10435
https://issues.apache.org/jira/browse/AMBARI-10435
Repository: ambari
Description
-------
No cardinality specified in metainfo.xml for HCAT component. Possibly for some another components either.
It's better to set cardinallity to some default value like "0+" insteand of null, which could lead to NPE
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 624227e
ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java 42d6944
ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java 1ae4cd1
Diff: https://reviews.apache.org/r/33077/diff/
Testing (updated)
-------
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ....................................... SUCCESS [4.028s]
[INFO] Apache Ambari Project POM ......................... SUCCESS [0.051s]
[INFO] Ambari Web ........................................ SUCCESS [37.284s]
[INFO] Ambari Views ...................................... SUCCESS [2.726s]
[INFO] Ambari Admin View ................................. SUCCESS [10.754s]
[INFO] Ambari Metrics Common ............................. SUCCESS [1.679s]
[INFO] Ambari Server ..................................... SUCCESS [1:20:01.930s]
[INFO] Ambari Agent ...................................... SUCCESS [9.098s]
[INFO] Ambari Client ..................................... SUCCESS [0.055s]
[INFO] Ambari Python Client .............................. SUCCESS [1.786s]
[INFO] Ambari Groovy Client .............................. SUCCESS [11.065s]
[INFO] Ambari Shell ...................................... SUCCESS [0.031s]
[INFO] Ambari Python Shell ............................... SUCCESS [0.040s]
[INFO] Ambari Groovy Shell ............................... SUCCESS [7.028s]
Thanks,
Dmytro Sen
Re: Review Request 33077: Set default cardinality for ComponentInfo
if not specified in metainfo.xml
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33077/
-----------------------------------------------------------
(Updated Апрель 10, 2015, 9:43 п.п.)
Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
Bugs: AMBARI-10435
https://issues.apache.org/jira/browse/AMBARI-10435
Repository: ambari
Description
-------
No cardinality specified in metainfo.xml for HCAT component. Possibly for some another components either.
It's better to set cardinallity to some default value like "0+" insteand of null, which could lead to NPE
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 624227e
ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java 42d6944
ambari-server/src/test/java/org/apache/ambari/server/stack/ServiceModuleTest.java 1ae4cd1
Diff: https://reviews.apache.org/r/33077/diff/
Testing
-------
!! some unit tests should be fixed
Thanks,
Dmytro Sen
Re: Review Request 33077: Set default cardinality for ComponentInfo
if not specified in metainfo.xml
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33077/
-----------------------------------------------------------
(Updated Апрель 10, 2015, 7:56 п.п.)
Review request for Ambari, Alejandro Fernandez and Dmitro Lisnichenko.
Bugs: AMBARI-10435
https://issues.apache.org/jira/browse/AMBARI-10435
Repository: ambari
Description
-------
No cardinality specified in metainfo.xml for HCAT component. Possibly for some another components either.
It's better to set cardinallity to some default value like "0+" insteand of null, which could lead to NPE
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 624227e
Diff: https://reviews.apache.org/r/33077/diff/
Testing (updated)
-------
!! some unit tests should be fixed
Thanks,
Dmytro Sen