You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@answer.apache.org by "sosyz (via GitHub)" <gi...@apache.org> on 2024/11/11 15:22:00 UTC

[PR] Add automatic footer to all system emails [incubator-answer]

sosyz opened a new pull request, #1172:
URL: https://github.com/apache/incubator-answer/pull/1172

   ## Description
   Added a standardized footer message to all outgoing system emails to inform users that these are automated messages and replies will not be monitored.
   
   ## Changes
   - Added new translation key for email footer in en_US.yaml
   - Added footer constant in email_tpl_key.go
   - Modified email service to append footer to all outgoing emails
   
   ## Testing
   - Verified footer appears correctly in all system emails
   - Confirmed footer text is properly translated
   - Tested email sending functionality remains intact
   
   Closes #1170


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add automatic footer to all system emails [incubator-answer]

Posted by "sosyz (via GitHub)" <gi...@apache.org>.
sosyz commented on PR #1172:
URL: https://github.com/apache/incubator-answer/pull/1172#issuecomment-2476679842

   @LinkinStars Li OK~ I add the test case.
   <img width="517" alt="image" src="https://github.com/user-attachments/assets/75934dbe-97bc-4fe3-8743-f2e4b64fcb16">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add automatic footer to all system emails [incubator-answer]

Posted by "sosyz (via GitHub)" <gi...@apache.org>.
sosyz commented on PR #1172:
URL: https://github.com/apache/incubator-answer/pull/1172#issuecomment-2476684270

   @LinkinStars OK~ I add the test case.
   <img width="522" alt="image" src="https://github.com/user-attachments/assets/42b2e013-9787-49f5-a301-467e1c41616a">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add automatic footer to all system emails [incubator-answer]

Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars commented on PR #1172:
URL: https://github.com/apache/incubator-answer/pull/1172#issuecomment-2476669062

   @sosyz Great! Thanks for the test cases.
   
   > invited_you_to_answer
   
   ![image](https://github.com/user-attachments/assets/6c58775d-0425-412a-8eb2-3c3be838a2b3)
   
   Admin can invite someone to ask the question.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add automatic footer to all system emails [incubator-answer]

Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars commented on PR #1172:
URL: https://github.com/apache/incubator-answer/pull/1172#issuecomment-2475203858

   @sosyz Since not all of them will have unsubscribe content, the easiest way for now, as you said, should be to modify the i18n file directly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add automatic footer to all system emails [incubator-answer]

Posted by "sosyz (via GitHub)" <gi...@apache.org>.
sosyz commented on PR #1172:
URL: https://github.com/apache/incubator-answer/pull/1172#issuecomment-2476621875

   @LinkinStars Hi~ I submitted a new commit
   This is my test.
   
   - [x] change_email
   - [x] new_answer
   - [ ] invited_you_to_answer (I don't know how to create this event😂)
   - [x] new_comment
   - [x] new_question
   - [x] pass_reset
   - [x] register
   - [x] test
   
   **change email**
   
   <img width="509" alt="image" src="https://github.com/user-attachments/assets/43d233c9-1777-4f57-b924-4bfeb07d16f2">
   
   ----
   
   **new answer**
   
   <img width="493" alt="image" src="https://github.com/user-attachments/assets/88c5e02c-2d0d-43cd-ae2e-e5c1a951b324">
   
   ----
   
   **comment post**
   
   <img width="516" alt="image" src="https://github.com/user-attachments/assets/98e7daf8-c493-4ced-80c5-bb4fefd7a75e">
   
   ----
   
   **new question**
   
   <img width="541" alt="image" src="https://github.com/user-attachments/assets/aa9ec9fb-8169-4131-a73c-e269e2bdaec6">
   
   ----
   
   **password reset**
   
   <img width="544" alt="image" src="https://github.com/user-attachments/assets/918c0913-fd91-4ec7-83ab-ee1798108bf7">
   
   ----
   
   **register account**
   
   <img width="523" alt="image" src="https://github.com/user-attachments/assets/40767c00-db67-4d00-b64f-61ca25e89ec9">
   
   ----
   
   **smtp test**
   
   <img width="500" alt="image" src="https://github.com/user-attachments/assets/a191c912-8f4f-4a46-a489-2825d340746a">
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add automatic footer to all system emails [incubator-answer]

Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars commented on PR #1172:
URL: https://github.com/apache/incubator-answer/pull/1172#issuecomment-2469783710

   ![image](https://github.com/user-attachments/assets/d6258d04-bf55-4838-8fef-23def9893e62)
   
   The style of email content is a little different from the design.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add automatic footer to all system emails [incubator-answer]

Posted by "LinkinStars (via GitHub)" <gi...@apache.org>.
LinkinStars merged PR #1172:
URL: https://github.com/apache/incubator-answer/pull/1172


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Add automatic footer to all system emails [incubator-answer]

Posted by "sosyz (via GitHub)" <gi...@apache.org>.
sosyz commented on PR #1172:
URL: https://github.com/apache/incubator-answer/pull/1172#issuecomment-2473954882

   @LinkinStars Hi! After reviewing this code, I noticed that the 'unsubscribe' content is generated through different email methods compiling their respective i18n configurations. I think it would be better to handle the 'unsubscribe' content in a unified way. What do you think? Alternatively, we could directly modify the i18n configuration to implement this prompt.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@answer.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org