You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2017/02/03 14:16:32 UTC
[GitHub] flink pull request #3262: [FLINK-5709] Add Max Parallelism to Parallel Execu...
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/3262
[FLINK-5709] Add Max Parallelism to Parallel Execution Doc
R: @rmetzger and @alpinegizmo (as the original writer of the parallelism doc).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink max-parallelism-doc
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3262.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3262
----
commit 1a6636be879c83b4e1f5b2c2983c352eb873f943
Author: Aljoscha Krettek <al...@gmail.com>
Date: 2017-02-03T14:15:10Z
[FLINK-5709] Add Max Parallelism to Parallel Execution Doc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3262: [FLINK-5709] Add Max Parallelism to Parallel Execu...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3262#discussion_r99372586
--- Diff: docs/dev/parallel.md ---
@@ -166,10 +177,19 @@ try {
</div>
-## System Level
+### System Level
A system-wide default parallelism for all execution environments can be defined by setting the
`parallelism.default` property in `./conf/flink-conf.yaml`. See the
[Configuration]({{ site.baseurl }}/setup/config.html) documentation for details.
+## Setting the Maximum Parallelism
--- End diff --
I added an "Attention" block. @rmetzger, do you think this is now good to merge?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3262: [FLINK-5709] Add Max Parallelism to Parallel Execu...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3262#discussion_r99563639
--- Diff: docs/dev/parallel.md ---
@@ -166,10 +177,19 @@ try {
</div>
-## System Level
+### System Level
A system-wide default parallelism for all execution environments can be defined by setting the
`parallelism.default` property in `./conf/flink-conf.yaml`. See the
[Configuration]({{ site.baseurl }}/setup/config.html) documentation for details.
+## Setting the Maximum Parallelism
--- End diff --
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3262: [FLINK-5709] Add Max Parallelism to Parallel Execu...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/3262#discussion_r99354689
--- Diff: docs/dev/parallel.md ---
@@ -166,10 +177,19 @@ try {
</div>
-## System Level
+### System Level
A system-wide default parallelism for all execution environments can be defined by setting the
`parallelism.default` property in `./conf/flink-conf.yaml`. See the
[Configuration]({{ site.baseurl }}/setup/config.html) documentation for details.
+## Setting the Maximum Parallelism
--- End diff --
I mention it in the introduction but I can also repeat it here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3262: [FLINK-5709] Add Max Parallelism to Parallel Execution Do...
Posted by alpinegizmo <gi...@git.apache.org>.
Github user alpinegizmo commented on the issue:
https://github.com/apache/flink/pull/3262
+1 looks good to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3262: [FLINK-5709] Add Max Parallelism to Parallel Execu...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3262#discussion_r99351570
--- Diff: docs/dev/parallel.md ---
@@ -166,10 +177,19 @@ try {
</div>
-## System Level
+### System Level
A system-wide default parallelism for all execution environments can be defined by setting the
`parallelism.default` property in `./conf/flink-conf.yaml`. See the
[Configuration]({{ site.baseurl }}/setup/config.html) documentation for details.
+## Setting the Maximum Parallelism
--- End diff --
Afaik, there's a performance impact for setting a high max parallelism. We should warn our users and give some rules of thumb for setting the max parallelism
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3262: [FLINK-5709] Add Max Parallelism to Parallel Execu...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/3262
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3262: [FLINK-5709] Add Max Parallelism to Parallel Execution Do...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/3262
Merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---