You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/03/21 11:18:02 UTC
[GitHub] [camel-kamelets] christophd opened a new pull request #846: chore: Overwrite JitPack dependencies for pull request builds
christophd opened a new pull request #846:
URL: https://github.com/apache/camel-kamelets/pull/846
This change in GitHub workflow definition enables PRs to use new/changed utility classes in module camel-kamelets-utils. The workflow overwrites the JitPack dependency coordinates in all Kamelets to point to the actual PR head ref instead of base (e.g. main-SNAPSHOT).
This ensures that the automated tests use the utility classes from that specific PR instead of those from the base branch (e.g. main-SNAPSHOT). So pull request builds are able to have a green GitHub CI workflow even if the base branch is not aware of the utility class before the merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] christophd commented on pull request #846: chore: Overwrite JitPack dependencies for pull request builds
Posted by GitBox <gi...@apache.org>.
christophd commented on pull request #846:
URL: https://github.com/apache/camel-kamelets/pull/846#issuecomment-1073904159
please bear with me as I need to find the proper github base ref value to extract from github context in order to make the PR a success
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd commented on pull request #846: chore: Overwrite JitPack dependencies for pull request builds
Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #846:
URL: https://github.com/apache/camel-kamelets/pull/846#issuecomment-1074091565
Thanks a lot!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] christophd commented on pull request #846: chore: Overwrite JitPack dependencies for pull request builds
Posted by GitBox <gi...@apache.org>.
christophd commented on pull request #846:
URL: https://github.com/apache/camel-kamelets/pull/846#issuecomment-1074060886
@oscerd ready now, it works!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-kamelets] oscerd merged pull request #846: chore: Overwrite JitPack dependencies for pull request builds
Posted by GitBox <gi...@apache.org>.
oscerd merged pull request #846:
URL: https://github.com/apache/camel-kamelets/pull/846
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org