You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Brian McDevitt (Code Review)" <ge...@cloudera.org> on 2018/12/31 18:22:51 UTC
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Brian McDevitt has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12141
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
KUDU-2411: Add OS/Arch detection to binary extract
OS/Arch detection ensures that the runtime has the appropriate Kudu
binaries to execute the MiniKuduCluster. Currently this limited to
OS: macosx|linux and Arch: x86_64.
Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
---
M java/gradle/dependencies.gradle
M java/kudu-test-utils/build.gradle
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java
M java/kudu-test-utils/src/test/resources/fake-kudu-binary/META-INF/apache-kudu-test-binary.properties
5 files changed, 23 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/12141/1
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
Patch Set 7: Code-Review+2
Looks good - thanks Brian!
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 7
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 29 Jan 2019 22:15:36 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
Patch Set 1:
(1 comment)
I will cleanup these items and rebase onto Mike's patch.
http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java:
http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java@67
PS1, Line 67: if (DETECTOR.getOs().equals(props.getProperty("artifact.os")) &&
> Should we log the OS and ARCH that we detected at INFO level for debugging
The underlying OsDetector class has builtin logging at the INFO level.
https://github.com/google/osdetector-gradle-plugin/blob/master/src/main/java/com/google/gradle/osdetector/OsDetector.java#L113
We can leverage that, or add explicit logging statements here.
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 03 Jan 2019 16:13:24 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
Patch Set 1:
> I was thinking we could create new classloader for those tests, that way we could append appropriate jars.
I put together the plumbing support for and an example of an end-to-end test at https://gerrit.cloudera.org/c/12147/ -- please take a look and let me know what you think. I took the simplest approach that I could find.
That patch conflicts with this one on a couple of lines because I removed the existing OS-detection logic due to it failing the test. I thought it was better to remove it than try to fix it because you are overhauling that part of the code in this patch right now.
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 03 Jan 2019 01:29:35 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
Patch Set 1:
It is not fully tested yet. We still need to add a positive test and a negative test. I was thinking we could create new classloader for those tests, that way we could append appropriate jars.
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 02 Jan 2019 22:12:50 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
Patch Set 3:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12141/3/java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
File java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java:
http://gerrit.cloudera.org:8080/#/c/12141/3/java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java@93
PS3, Line 93: OutputStream propsOutputStream = Files.newOutputStream(propsPath);
Getting this error on Jenkins:
JUnit version 4.12
.17:13:58.612 [INFO - main] (TestKuduBinaryJarExtractor.java:57) Creating fake kudu binary jar at /tmp/fake-osx-kudu-binary7070665978496634390/fake-osx-kudu-binary.jar
E.17:13:58.640 [INFO - main] (TestKuduBinaryJarExtractor.java:57) Creating fake kudu binary jar at /tmp/fake-osx-kudu-binary5332688690569538223/fake-osx-kudu-binary.jar
E
Time: 0.048
There were 2 failures:
1) testExtractJar(org.apache.kudu.test.cluster.TestKuduBinaryJarExtractor)
java.nio.file.NoSuchFileException: META-INF/
at com.sun.nio.zipfs.ZipFileSystem.checkParents(ZipFileSystem.java:863)
at com.sun.nio.zipfs.ZipFileSystem.newOutputStream(ZipFileSystem.java:528)
at com.sun.nio.zipfs.ZipPath.newOutputStream(ZipPath.java:790)
at com.sun.nio.zipfs.ZipFileSystemProvider.newOutputStream(ZipFileSystemProvider.java:285)
at java.nio.file.Files.newOutputStream(Files.java:216)
at org.apache.kudu.test.cluster.TestKuduBinaryJarExtractor.createKuduBinaryJar(TestKuduBinaryJarExtractor.java:93)
at org.apache.kudu.test.cluster.TestKuduBinaryJarExtractor.testExtractJar(TestKuduBinaryJarExtractor.java:127)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
at org.junit.runner.JUnitCore.runMain(JUnitCore.java:77)
at org.junit.runner.JUnitCore.main(JUnitCore.java:36)
2) testIsKuduBinaryJarOnClasspath(org.apache.kudu.test.cluster.TestKuduBinaryJarExtractor)
java.nio.file.NoSuchFileException: META-INF/
at com.sun.nio.zipfs.ZipFileSystem.checkParents(ZipFileSystem.java:863)
at com.sun.nio.zipfs.ZipFileSystem.newOutputStream(ZipFileSystem.java:528)
at com.sun.nio.zipfs.ZipPath.newOutputStream(ZipPath.java:790)
at com.sun.nio.zipfs.ZipFileSystemProvider.newOutputStream(ZipFileSystemProvider.java:285)
at java.nio.file.Files.newOutputStream(Files.java:216)
at org.apache.kudu.test.cluster.TestKuduBinaryJarExtractor.createKuduBinaryJar(TestKuduBinaryJarExtractor.java:93)
at org.apache.kudu.test.cluster.TestKuduBinaryJarExtractor.testIsKuduBinaryJarOnClasspath(TestKuduBinaryJarExtractor.java:146)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
at org.junit.runner.JUnitCore.runMain(JUnitCore.java:77)
at org.junit.runner.JUnitCore.main(JUnitCore.java:36)
FAILURES!!!
Tests run: 2, Failures: 2
http://gerrit.cloudera.org:8080/#/c/12141/3/java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java@127
PS3, Line 127: "osx"
For a positive test we can just use the OS detector to make it match, since we're not testing the OS detector, we're just testing our comparison logic. For a negative test we could just use some unsupported OS like "windows" or something
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 3
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 04 Jan 2019 19:19:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
Patch Set 5:
> Patch Set 5:
>
> One new failure:
>
> /home/jenkins-slave/workspace/kudu-master/0/src/kudu/integration-tests/dense_node-itest.cc:217
> Failed
> Bad status: Runtime error: /tmp/dist-test-taskashoUq/build/release/bin/kudu-tserver: process exited on signal 6 (core dumpe
You can ignore that; it's a failure that He Lifu is working on (https://gerrit.cloudera.org/c/12239).
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 5
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 24 Jan 2019 23:49:44 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
Patch Set 5:
(3 comments)
Updated with the specified changes.
http://gerrit.cloudera.org:8080/#/c/12141/5/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java
File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java:
http://gerrit.cloudera.org:8080/#/c/12141/5/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java@88
PS5, Line 88: "Set the system variable " + KUDU_BIN_DIR_PROP +
> please update this message to include something like:
Done
http://gerrit.cloudera.org:8080/#/c/12141/5/java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
File java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java:
http://gerrit.cloudera.org:8080/#/c/12141/5/java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java@93
PS5, Line 93: customize
> nit: Just a style guide thing, please capitalize the first word in the sent
Done
http://gerrit.cloudera.org:8080/#/c/12141/5/java/kudu-test-utils/src/test/resources/log4j.properties
File java/kudu-test-utils/src/test/resources/log4j.properties:
http://gerrit.cloudera.org:8080/#/c/12141/5/java/kudu-test-utils/src/test/resources/log4j.properties@24
PS5, Line 24: log4j.logger.com.google.gradle = INFO
> Please add a comment as to why this is necessary / useful
Done
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 5
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 28 Jan 2019 15:15:28 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12141
to look at the new patch set (#4).
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
KUDU-2411: Add OS/Arch detection to binary extract
OS/Arch detection ensures that the runtime has the appropriate Kudu
binaries to execute the MiniKuduCluster. Currently this limited to
OS: osx|linux and Arch: x86_64.
Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
---
M java/gradle/dependencies.gradle
M java/kudu-test-utils/build.gradle
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
D java/kudu-test-utils/src/test/resources/fake-kudu-binary/META-INF/apache-kudu-test-binary.properties
M java/kudu-test-utils/src/test/resources/log4j.properties
7 files changed, 58 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/12141/4
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 4
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
KUDU-2411: Add OS/Arch detection to binary extract
OS/Arch detection ensures that the runtime has the appropriate Kudu
binaries to execute the MiniKuduCluster. Currently this limited to
OS: osx|linux and Arch: x86_64.
Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Reviewed-on: http://gerrit.cloudera.org:8080/12141
Tested-by: Kudu Jenkins
Reviewed-by: Mike Percy <mp...@apache.org>
---
M java/gradle/dependencies.gradle
M java/kudu-test-utils/build.gradle
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
D java/kudu-test-utils/src/test/resources/fake-kudu-binary/META-INF/apache-kudu-test-binary.properties
M java/kudu-test-utils/src/test/resources/log4j.properties
7 files changed, 62 insertions(+), 32 deletions(-)
Approvals:
Kudu Jenkins: Verified
Mike Percy: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 8
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/build.gradle
File java/kudu-test-utils/build.gradle:
http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/build.gradle@23
PS1, Line 23: compile libs.osdetector
> This will be shaded given the shadow.gradle script is applied and it's in c
Ah, I never really understood how that worked. Just looked. Nice job on that.
http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java:
http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java@67
PS1, Line 67: if (DETECTOR.getOs().equals(props.getProperty("artifact.os")) &&
> The underlying OsDetector class has builtin logging at the INFO level.
Good idea, yes as long as the os / arch get logged then I'm +1 to letting the plugin do it.
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 03 Jan 2019 17:17:15 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12141
to look at the new patch set (#6).
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
KUDU-2411: Add OS/Arch detection to binary extract
OS/Arch detection ensures that the runtime has the appropriate Kudu
binaries to execute the MiniKuduCluster. Currently this limited to
OS: osx|linux and Arch: x86_64.
Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
---
M java/gradle/dependencies.gradle
M java/kudu-test-utils/build.gradle
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
D java/kudu-test-utils/src/test/resources/fake-kudu-binary/META-INF/apache-kudu-test-binary.properties
M java/kudu-test-utils/src/test/resources/log4j.properties
7 files changed, 62 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/12141/6
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 6
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
Patch Set 1:
(3 comments)
I think you will need to rebase onto Mikes Classloader patc and fix the collisions.
http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/build.gradle
File java/kudu-test-utils/build.gradle:
http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/build.gradle@23
PS1, Line 23: compile libs.osdetector
> This looks good. I wonder if Grant can help us ensure it's shaded.
This will be shaded given the shadow.gradle script is applied and it's in compile scope.
http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java:
http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java@52
PS1, Line 52: private static OsDetector DETECTOR = new OsDetector();
nit: final
http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java@67
PS1, Line 67: if (DETECTOR.getOs().equals(props.getProperty("artifact.os")) &&
Should we log the OS and ARCH that we detected at INFO level for debugging purposes?
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 03 Jan 2019 15:58:33 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
Patch Set 1:
> I will cleanup these items and rebase onto Mike's patch.
I just merged my patch from CR 12147, so you can just rebase onto origin/master now.
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 03 Jan 2019 19:27:53 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Looks good. Is it tested yet?
http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/build.gradle
File java/kudu-test-utils/build.gradle:
http://gerrit.cloudera.org:8080/#/c/12141/1/java/kudu-test-utils/build.gradle@23
PS1, Line 23: compile libs.osdetector
This looks good. I wonder if Grant can help us ensure it's shaded.
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 1
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Wed, 02 Jan 2019 08:00:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
Patch Set 5:
(3 comments)
Looking good, I just have some minor comments
http://gerrit.cloudera.org:8080/#/c/12141/5/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java
File java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java:
http://gerrit.cloudera.org:8080/#/c/12141/5/java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java@88
PS5, Line 88: "Set the system variable " + KUDU_BIN_DIR_PROP +
please update this message to include something like:
"Set the system variable " + KUDU_BIN_DIR_PROP +
" or add the Kudu binary test jar to your classpath or ensure the `kudu` binary is on your path."
http://gerrit.cloudera.org:8080/#/c/12141/5/java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
File java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java:
http://gerrit.cloudera.org:8080/#/c/12141/5/java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java@93
PS5, Line 93: customize
nit: Just a style guide thing, please capitalize the first word in the sentence in a comment. Also please end the sentence with punctuation such as a period.
http://gerrit.cloudera.org:8080/#/c/12141/5/java/kudu-test-utils/src/test/resources/log4j.properties
File java/kudu-test-utils/src/test/resources/log4j.properties:
http://gerrit.cloudera.org:8080/#/c/12141/5/java/kudu-test-utils/src/test/resources/log4j.properties@24
PS5, Line 24: log4j.logger.com.google.gradle = INFO
Please add a comment as to why this is necessary / useful
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 5
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Fri, 25 Jan 2019 07:32:23 +0000
Gerrit-HasComments: Yes
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
Patch Set 5:
One new failure:
/home/jenkins-slave/workspace/kudu-master/0/src/kudu/integration-tests/dense_node-itest.cc:217
Failed
Bad status: Runtime error: /tmp/dist-test-taskashoUq/build/release/bin/kudu-tserver: process exited on signal 6 (core dumpe
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 5
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 24 Jan 2019 23:30:25 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12141
to look at the new patch set (#2).
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
KUDU-2411: Add OS/Arch detection to binary extract
OS/Arch detection ensures that the runtime has the appropriate Kudu
binaries to execute the MiniKuduCluster. Currently this limited to
OS: osx|linux and Arch: x86_64.
Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
---
M java/gradle/dependencies.gradle
M java/kudu-test-utils/build.gradle
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
D java/kudu-test-utils/src/test/resources/fake-kudu-binary/META-INF/apache-kudu-test-binary.properties
M java/kudu-test-utils/src/test/resources/log4j.properties
7 files changed, 56 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/12141/2
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 2
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
Patch Set 4:
> Patch Set 4:
>
> Jenkins appears to fail on unrelated Python code:
>
> 14:54:22 Command "/home/jenkins-slave/workspace/kudu-master/1/build/debug/py_env/bin/python3 /home/jenkins-slave/workspace/kudu-master/1/build/debug/py_env/lib/python3.4/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmpd978xbq3" failed with error code 1 in /tmp/pip-install-zklrwiys/pandas
If you rebase this change onto the tip of master, you'll get a fix for that failure.
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 4
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 24 Jan 2019 23:06:10 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Brian McDevitt has posted comments on this change. ( http://gerrit.cloudera.org:8080/12141 )
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
Patch Set 4:
Jenkins appears to fail on unrelated Python code:
14:54:22 Command "/home/jenkins-slave/workspace/kudu-master/1/build/debug/py_env/bin/python3 /home/jenkins-slave/workspace/kudu-master/1/build/debug/py_env/lib/python3.4/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmpd978xbq3" failed with error code 1 in /tmp/pip-install-zklrwiys/pandas
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 4
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Thu, 24 Jan 2019 23:01:19 +0000
Gerrit-HasComments: No
[kudu-CR] KUDU-2411: Add OS/Arch detection to binary extract
Posted by "Brian McDevitt (Code Review)" <ge...@cloudera.org>.
Hello Mike Percy, Kudu Jenkins, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12141
to look at the new patch set (#3).
Change subject: KUDU-2411: Add OS/Arch detection to binary extract
......................................................................
KUDU-2411: Add OS/Arch detection to binary extract
OS/Arch detection ensures that the runtime has the appropriate Kudu
binaries to execute the MiniKuduCluster. Currently this limited to
OS: osx|linux and Arch: x86_64.
Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
---
M java/gradle/dependencies.gradle
M java/kudu-test-utils/build.gradle
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryJarExtractor.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/cluster/KuduBinaryLocator.java
M java/kudu-test-utils/src/test/java/org/apache/kudu/test/cluster/TestKuduBinaryJarExtractor.java
D java/kudu-test-utils/src/test/resources/fake-kudu-binary/META-INF/apache-kudu-test-binary.properties
M java/kudu-test-utils/src/test/resources/log4j.properties
7 files changed, 56 insertions(+), 29 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/41/12141/3
--
To view, visit http://gerrit.cloudera.org:8080/12141
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9752914a426dd1572610f891dad4d4778d04f79c
Gerrit-Change-Number: 12141
Gerrit-PatchSet: 3
Gerrit-Owner: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Brian McDevitt <br...@phdata.io>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>