You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by xu...@apache.org on 2015/10/28 13:11:45 UTC
[52/55] [abbrv] hive git commit: HIVE-12227 : LLAP: better column
vector object pools (Sergey Shelukhin, reviewed by Gopal V)
HIVE-12227 : LLAP: better column vector object pools (Sergey Shelukhin, reviewed by Gopal V)
Project: http://git-wip-us.apache.org/repos/asf/hive/repo
Commit: http://git-wip-us.apache.org/repos/asf/hive/commit/f2ede0e7
Tree: http://git-wip-us.apache.org/repos/asf/hive/tree/f2ede0e7
Diff: http://git-wip-us.apache.org/repos/asf/hive/diff/f2ede0e7
Branch: refs/heads/spark
Commit: f2ede0e728c9740d7f7c37bbc342ada7df11b1aa
Parents: e5b5303
Author: Sergey Shelukhin <se...@apache.org>
Authored: Tue Oct 27 18:26:03 2015 -0700
Committer: Sergey Shelukhin <se...@apache.org>
Committed: Tue Oct 27 18:26:03 2015 -0700
----------------------------------------------------------------------
.../apache/hadoop/hive/llap/io/decode/EncodedDataConsumer.java | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hive/blob/f2ede0e7/llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/EncodedDataConsumer.java
----------------------------------------------------------------------
diff --git a/llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/EncodedDataConsumer.java b/llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/EncodedDataConsumer.java
index 23c2c51..b81e97d 100644
--- a/llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/EncodedDataConsumer.java
+++ b/llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/EncodedDataConsumer.java
@@ -42,9 +42,8 @@ public abstract class EncodedDataConsumer<BatchKey, BatchType extends EncodedCol
private final Consumer<ColumnVectorBatch> downstreamConsumer;
private Callable<Void> readCallable;
private final LlapDaemonQueueMetrics queueMetrics;
- // TODO: if we were using Exchanger, pool would not be necessary here - it would be 1/N items
- private final static int CVB_POOL_SIZE = 8;
// Note that the pool is per EDC - within EDC, CVBs are expected to have the same schema.
+ private final static int CVB_POOL_SIZE = 128;
protected final FixedSizedObjectPool<ColumnVectorBatch> cvbPool;
public EncodedDataConsumer(Consumer<ColumnVectorBatch> consumer, final int colCount,
@@ -59,6 +58,7 @@ public abstract class EncodedDataConsumer<BatchKey, BatchType extends EncodedCol
}
@Override
public void resetBeforeOffer(ColumnVectorBatch t) {
+ // Don't reset anything, we are reusing column vectors.
}
});
}