[GitHub] [nifi] MikeThomsen commented on a change in pull request #5362: NIFI-9149 to NIFI-9163 (JUnit 5 refactor)

[GitBox <gi...@apache.org>]

MikeThomsen commented on a change in pull request #5362:
URL: https://github.com/apache/nifi/pull/5362#discussion_r754572431



##########
File path: nifi-nar-bundles/nifi-site-to-site-reporting-bundle/nifi-site-to-site-reporting-task/src/test/java/org/apache/nifi/reporting/TestSiteToSiteMetricsReportingTask.java
##########
@@ -319,7 +302,7 @@ public void setup(ReportingContext reportContext) throws IOException {
                     when(client.createTransaction(Mockito.any(TransferDirection.class))).thenReturn(transaction);
                 } catch (final Exception e) {
                     e.printStackTrace();
-                    Assert.fail(e.toString());
+                    fail(e.toString());

Review comment:
       Changed the whole block to `assertDoesNotThrow` since that's the better fit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org