You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mnemonic.apache.org by "Yanhui Zhao (Jira)" <ji...@apache.org> on 2021/06/17 05:34:00 UTC

[jira] [Commented] (MNEMONIC-657) Mnemonic release script should be updated to remove compiled code files in prepared release candidates

    [ https://issues.apache.org/jira/browse/MNEMONIC-657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17364698#comment-17364698 ] 

Yanhui Zhao commented on MNEMONIC-657:
--------------------------------------

The mnemonic project gradle folder contained compiled jar file gradle-wrapper, which is suggested to be removed from our project.

I did some test that we can remove the gradlew and gradle/ from our project by replacing ./gradlw build with gradle build (required gradle version > 4.6). Some 3rd-party dependencies were seen but those can be easily fixed by walking through build.gradle

> Mnemonic release script should be updated to remove compiled code files in prepared release candidates
> ------------------------------------------------------------------------------------------------------
>
>                 Key: MNEMONIC-657
>                 URL: https://issues.apache.org/jira/browse/MNEMONIC-657
>             Project: Mnemonic
>          Issue Type: Bug
>          Components: Build, Release, Tools
>    Affects Versions: 0.15.0
>            Reporter: Yanhui Zhao
>            Priority: Major
>             Fix For: 0.15.0
>
>
> Justin pointed out that our release contains compiled code files that are not encouraged to included in the release file. Those should be removed and release script may need to be updated for future releases.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)