[jira] Updated: (CLK-612) Better user experience with DateField (and CalendarField).

["Andrey Rybin (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CLK-612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrey Rybin updated CLK-612:
-----------------------------

    Description: 
Current DateField.validate() is too strict. 

My suggestion is:

Add String property   similarDelimiters:

its format:   [oldChar1][newChar1] [oldChar2][newChar2]....

if odd then ignore last char.


Modify setValue (not tested):

    public void setValue(String value) {
        if (value != null && value.length() > 0) {
           value = value.trim();

     if (similarDelimiters != null && similarDelimiters.length > 0) {
       for (int i=0; i<similarDelimiters.length-1; i+=2) {
         value = value.replace(similarDelimiters.charAt(i), similarDelimiters.charAt(i+1));
      }//f
     }//i

            try {
                Date parsedDate = getDateFormat().parse(value);

                // Cache date for subsequent retrievals
                date = new Date(parsedDate.getTime());

            } catch (ParseException pe) {
                date = null;
            }

        } else {
            date = null;
        }
        super.setValue(value);
    }//setValue

Because many people around me use /,-,.(dot) as date delimiters, not only / for example.

So I will set similarDelimiters to "-/\\/./" and pattern to dd/MM/yyyy - and it will work.

  was:
Current DateField.validate() is too strict. 

My suggestion is:

Add String property   similarDelimiters:

its format:   [oldChar1][newChar1] [oldChar2][newChar2]....

if odd then ignore last char.

And add this to validate() method (not tested):

  dateFormat.setLenient(false);

  String v = getValue().trim();
  if (similarDelimiters != null && similarDelimiters.length > 0) {
    for (int i=0; i<similarDelimiters.length-1; i+=2) {
      v = v.replace(similarDelimiters.charAt(i), similarDelimiters.charAt(i+1));
   }//f
  }//i

   try {
   dateFormat.parse(v).getTime();
  } catch (ParseException pe) {


Because many people around me use /,-,.(dot) as date delimiters, not only / for example.



> Better user experience with DateField (and CalendarField).
> ----------------------------------------------------------
>
>                 Key: CLK-612
>                 URL: https://issues.apache.org/jira/browse/CLK-612
>             Project: Click
>          Issue Type: Improvement
>    Affects Versions: 2.1.0, 2.1.0 RC1
>            Reporter: Andrey Rybin
>
> Current DateField.validate() is too strict. 
> My suggestion is:
> Add String property   similarDelimiters:
> its format:   [oldChar1][newChar1] [oldChar2][newChar2]....
> if odd then ignore last char.
> Modify setValue (not tested):
>     public void setValue(String value) {
>         if (value != null && value.length() > 0) {
>            value = value.trim();
>      if (similarDelimiters != null && similarDelimiters.length > 0) {
>        for (int i=0; i<similarDelimiters.length-1; i+=2) {
>          value = value.replace(similarDelimiters.charAt(i), similarDelimiters.charAt(i+1));
>       }//f
>      }//i
>             try {
>                 Date parsedDate = getDateFormat().parse(value);
>                 // Cache date for subsequent retrievals
>                 date = new Date(parsedDate.getTime());
>             } catch (ParseException pe) {
>                 date = null;
>             }
>         } else {
>             date = null;
>         }
>         super.setValue(value);
>     }//setValue
> Because many people around me use /,-,.(dot) as date delimiters, not only / for example.
> So I will set similarDelimiters to "-/\\/./" and pattern to dd/MM/yyyy - and it will work.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.