You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Wei-Chiu Chuang (Jira)" <ji...@apache.org> on 2021/04/23 08:30:00 UTC

[jira] [Comment Edited] (HDFS-15624) Fix the SetQuotaByStorageTypeOp problem after updating hadoop

    [ https://issues.apache.org/jira/browse/HDFS-15624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17329956#comment-17329956 ] 

Wei-Chiu Chuang edited comment on HDFS-15624 at 4/23/21, 8:29 AM:
------------------------------------------------------------------

Hi looks like we have a problem here. I'm going to reopen this issue.
For details, please see my discussion thread: https://lists.apache.org/thread.html/rbdd58fda1b528c345713f902c6a659fa1fc8671cbf67f59fc31e25ee%40%3Chdfs-dev.hadoop.apache.org%3E

{quote}
In HDFS-15624 (fix the function of setting quota by storage type), A new
layout version was added
NVDIMM_SUPPORT(-66, -61, "Support NVDIMM storage type");
This was added for 3.4.0 (trunk)

However, there's another jira
HDFS-15566 (NN restart fails after RollingUpgrade from 3.1.3/3.2.1 to 3.3.0)
SNAPSHOT_MODIFICATION_TIME(-66, -61, "Support modification time for
snapshot");

where Brahma wanted to add a new layout version in branch-3.3 (3.3.1). The
patch got stalled awhile ago and I'm trying to commit it in preparation of
3.3.1 release.

However, both new layout versions conflict because they intend to use the
new same version id. We can't release 3.3.1 without HDFS-15566 but we can't
use layout id -66 because of HDFS-15624.

I propose:
revert HDFS-15624 (NVDIMM_SUPPORT),
commit HDFS-15566 (SNAPSHOT_MODIFICATION_TIME)
re-work on HDFS-15624 but with layout version id -67
{quote}


was (Author: jojochuang):
Hi looks like we have a problem here. I'm going to reopen this issue.
For details, please see my discussion thread: https://lists.apache.org/thread.html/rbdd58fda1b528c345713f902c6a659fa1fc8671cbf67f59fc31e25ee%40%3Chdfs-dev.hadoop.apache.org%3E

>  Fix the SetQuotaByStorageTypeOp problem after updating hadoop 
> ---------------------------------------------------------------
>
>                 Key: HDFS-15624
>                 URL: https://issues.apache.org/jira/browse/HDFS-15624
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs
>    Affects Versions: 3.4.0
>            Reporter: YaYun Wang
>            Assignee: huangtianhua
>            Priority: Major
>              Labels: pull-request-available, release-blocker
>             Fix For: 3.4.0
>
>          Time Spent: 9h 40m
>  Remaining Estimate: 0h
>
> HDFS-15025 adds a new storage Type NVDIMM, changes the ordinal() of the enum of StorageType. And, setting the quota by storageType depends on the ordinal(), therefore, it may cause the setting of quota to be invalid after upgrade.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-help@hadoop.apache.org