You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2008/08/23 10:54:48 UTC

svn commit: r688279 - in /activemq/camel/trunk/camel-core/src/main/java/org/apache/camel: ./ impl/ impl/converter/ management/ spi/

Author: davsclaus
Date: Sat Aug 23 01:54:47 2008
New Revision: 688279

URL: http://svn.apache.org/viewvc?rev=688279&view=rev
Log:
CAMEL-839: Debug log for no type converter found. Polished javadoc.

Modified:
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/TypeConverter.java
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/DefaultLifecycleStrategy.java
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/converter/DefaultTypeConverter.java
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/management/InstrumentationLifecycleStrategy.java
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/BrowsableEndpoint.java
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/DataFormat.java
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/ErrorHandlerWrappingStrategy.java
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/ExchangeConverter.java
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/HeaderFilterStrategy.java
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/InstrumentationAgent.java
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/Language.java
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/LanguageResolver.java
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/LifecycleStrategy.java
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/Provider.java
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/RouteContext.java
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/Synchronization.java
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/TypeConverterAware.java
    activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/UnitOfWork.java

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/TypeConverter.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/TypeConverter.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/TypeConverter.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/TypeConverter.java Sat Aug 23 01:54:47 2008
@@ -25,25 +25,26 @@
  * @version $Revision$
  */
 public interface TypeConverter {
+
     /**
      * Converts the value to the specified type
      * 
      * @param type the requested type
      * @param value the value to be converted
-     * @return the converted value or null if it can not be converted
+     * @return the converted value or <tt>null</tt> if it can not be converted
      */
     <T> T convertTo(Class<T> type, Object value);
 
     /**
      * Converts the value to the specified type in the context of an exchange
-     * 
+     * <p/>
+     * Used when conversion requires extra information from the current
+     * exchange (such as encoding).
+     *
      * @param type the requested type
-     * @param current exchange
+     * @param exchange the current exchange
      * @param value the value to be converted
-     * @return the converted value or null if it can not be converted
-     * 
-     * Used when conversion requires extra information from the current 
-     * exchange (such as encoding).
+     * @return the converted value or <tt>null</tt> if it can not be converted
      */
     <T> T convertTo(Class<T> type, Exchange exchange, Object value);
 }

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/DefaultLifecycleStrategy.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/DefaultLifecycleStrategy.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/DefaultLifecycleStrategy.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/DefaultLifecycleStrategy.java Sat Aug 23 01:54:47 2008
@@ -25,10 +25,6 @@
 import org.apache.camel.Exchange;
 import org.apache.camel.Route;
 import org.apache.camel.Service;
-import org.apache.camel.builder.DeadLetterChannelBuilder;
-import org.apache.camel.management.InstrumentationErrorHandlerWrappingStrategy;
-import org.apache.camel.management.InstrumentationProcessor;
-import org.apache.camel.model.ExceptionType;
 import org.apache.camel.model.ProcessorType;
 import org.apache.camel.model.RouteType;
 import org.apache.camel.spi.LifecycleStrategy;
@@ -56,7 +52,6 @@
     }
 
     public void onRouteContextCreate(RouteContext routeContext) {
-
         RouteType routeType = routeContext.getRoute();
         if (routeType.getInputs() != null && !routeType.getInputs().isEmpty()) {
             // configure the outputs
@@ -69,8 +64,7 @@
             for (ProcessorType<?> processorType : outputs) {
                 routeType.addOutput(processorType);
             }
-
         }
-
     }
+
 }

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/converter/DefaultTypeConverter.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/converter/DefaultTypeConverter.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/converter/DefaultTypeConverter.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/impl/converter/DefaultTypeConverter.java Sat Aug 23 01:54:47 2008
@@ -64,15 +64,21 @@
 
     @SuppressWarnings("unchecked")
     public <T> T convertTo(Class<T> type, Exchange exchange, Object value) {
+        // same instance type
         if (type.isInstance(value)) {
             return type.cast(value);
         }
+
+        // make sure we have loaded the converters
         checkLoaded();
+
+        // try to find a suitable type converter
         TypeConverter converter = getOrFindTypeConverter(type, value);
         if (converter != null) {
             return converter.convertTo(type, exchange, value);
         }
 
+        // fallback converters
         for (TypeConverter fallback : fallbackConverters) {
             T rc = fallback.convertTo(type, exchange, value);
             if (rc != null) {
@@ -84,12 +90,20 @@
         if (boolean.class.isAssignableFrom(type)) {
             return (T) Boolean.FALSE;
         }
+
+        // primitives
         if (type.isPrimitive()) {
             Class primitiveType = ObjectHelper.convertPrimitiveTypeToWrapperType(type);
             if (primitiveType != type) {
                 return (T) convertTo(primitiveType, exchange, value);
             }
         }
+
+        if (LOG.isDebugEnabled()) {
+            LOG.debug("Could not find a type converter for converting "
+                + value.getClass().getCanonicalName() + " -> " + type.getCanonicalName()
+                + " with value: " + value);
+        }
         return null;
     }
 

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/management/InstrumentationLifecycleStrategy.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/management/InstrumentationLifecycleStrategy.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/management/InstrumentationLifecycleStrategy.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/management/InstrumentationLifecycleStrategy.java Sat Aug 23 01:54:47 2008
@@ -46,7 +46,6 @@
  * JMX agent that registeres Camel lifecycle events in JMX.
  *
  * @version $Revision$
- *
  */
 public class InstrumentationLifecycleStrategy implements LifecycleStrategy {
     private static final transient Log LOG = LogFactory.getLog(InstrumentationProcessor.class);
@@ -70,11 +69,10 @@
     /**
      * Constructor for camel context that has been started.
      *
-     * @param agent
-     * @param context
+     * @param agent    the agent
+     * @param context  the camel context
      */
-    public InstrumentationLifecycleStrategy(InstrumentationAgent agent,
-            CamelContext context) {
+    public InstrumentationLifecycleStrategy(InstrumentationAgent agent, CamelContext context) {
         this.agent = agent;
         onContextStart(context);
     }
@@ -96,7 +94,6 @@
     }
 
     public void onEndpointAdd(Endpoint<? extends Exchange> endpoint) {
-
         // the agent hasn't been started
         if (!initialized) {
             return;
@@ -111,7 +108,6 @@
     }
 
     public void onRoutesAdd(Collection<Route> routes) {
-
         // the agent hasn't been started
         if (!initialized) {
             return;
@@ -136,7 +132,6 @@
     }
 
     public void onServiceAdd(CamelContext context, Service service) {
-
         // the agent hasn't been started
         if (!initialized) {
             return;
@@ -152,7 +147,6 @@
     }
 
     public void onRouteContextCreate(RouteContext routeContext) {
-
         // the agent hasn't been started
         if (!initialized) {
             return;
@@ -249,4 +243,5 @@
     public void setAgent(InstrumentationAgent agent) {
         this.agent = agent;
     }
+
 }

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/BrowsableEndpoint.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/BrowsableEndpoint.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/BrowsableEndpoint.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/BrowsableEndpoint.java Sat Aug 23 01:54:47 2008
@@ -22,12 +22,13 @@
 import org.apache.camel.Exchange;
 
 /**
- * An optional interface an {@link Endpoint} may choose to implement which allows it to expose a way of browsing
- * the exchanges available.
+ * An optional interface an {@link Endpoint} may choose to implement which allows it to
+ * expose a way of browsing the exchanges available.
  *
  * @version $Revision$
  */
 public interface BrowsableEndpoint<T extends Exchange> extends Endpoint<T> {
+
     /**
      * Return the exchanges available on this endpoint
      *

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/DataFormat.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/DataFormat.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/DataFormat.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/DataFormat.java Sat Aug 23 01:54:47 2008
@@ -34,6 +34,11 @@
 
     /**
      * Marshals the object to the given Stream.
+     *
+     * @param exchange  the current exchange
+     * @param graph     the object to be marshalled
+     * @param stream    the output stream to write the marshalled rersult to
+     * @throws Exception can be thrown
      */
     void marshal(Exchange exchange, Object graph, OutputStream stream) throws Exception;
 
@@ -43,6 +48,11 @@
      * <b>Notice:</b> The result is set as body on the exchange OUT message.
      * It is possible to mutate the OUT message provided in the given exchange parameter.
      * For instance adding headers to the OUT message will be preserved.
+     *
+     * @param exchange    the current exchange
+     * @param stream      the input stream with the object to be unmarshalled
+     * @return            the unmarshalled object
+     * @throws Exception can be thrown
      */
     Object unmarshal(Exchange exchange, InputStream stream) throws Exception;
 }

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/ErrorHandlerWrappingStrategy.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/ErrorHandlerWrappingStrategy.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/ErrorHandlerWrappingStrategy.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/ErrorHandlerWrappingStrategy.java Sat Aug 23 01:54:47 2008
@@ -33,6 +33,7 @@
      * to give the implementor an opportunity to wrap the target processor
      * in a route.
      *
+     * @param routeContext the route context
      * @param processorType the object that invokes this method
      * @param target the processor to be wrapped
      * @return processor wrapped with an interceptor or not wrapped

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/ExchangeConverter.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/ExchangeConverter.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/ExchangeConverter.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/ExchangeConverter.java Sat Aug 23 01:54:47 2008
@@ -25,5 +25,13 @@
  */
 public interface ExchangeConverter {
 
+    /**
+     * Converts the given exchange to the new type
+     *
+     * @param type  the new class type
+     * @param exchange the exchange to converter
+     * @param <T> the new type
+     * @return  the converted exchange
+     */
      <T> T  convertTo(Class<T> type, Exchange exchange);
 }

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/HeaderFilterStrategy.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/HeaderFilterStrategy.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/HeaderFilterStrategy.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/HeaderFilterStrategy.java Sat Aug 23 01:54:47 2008
@@ -31,9 +31,9 @@
      * It returns true if the filtering logics return a match.  Otherwise,
      * it returns false.  A match means the header should be excluded.
      * 
-     * @param headerName 
-     * @param headerValue
-     * @return true if this header should be filtered out.
+     * @param headerName  the header name
+     * @param headerValue the header value
+     * @return <tt>true</tt> if this header should be filtered out.
      */
     boolean applyFilterToCamelHeaders(String headerName, Object headerValue);
 
@@ -45,11 +45,10 @@
      * It returns true if the filtering logics return a match.  Otherwise,
      * it returns false.  A match means the header should be excluded.
      *  
-     * @param headerName 
-     * @param headerValue
-     * @return true if this header should be filtered out.
+     * @param headerName  the header name
+     * @param headerValue the header value
+     * @return <tt>true</tt> if this header should be filtered out.
      */
     boolean applyFilterToExternalHeaders(String headerName, Object headerValue);
-
     
 }

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/InstrumentationAgent.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/InstrumentationAgent.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/InstrumentationAgent.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/InstrumentationAgent.java Sat Aug 23 01:54:47 2008
@@ -60,19 +60,20 @@
     /**
      * Get the MBeanServer which hosts managed objects.
      * <p/>
-     * NOTE: if the JMXEnabled configuration is not set to true, this method will return null.
+     * <b>Notice:</b> If the JMXEnabled configuration is not set to <tt>true</tt>,
+     * this method will return <tt>null</tt>.
      * 
      * @return the MBeanServer
      */
     MBeanServer getMBeanServer();
 
     /**
-     * Get domain name for Camel MBeans.  Notice that this can be different that the 
-     * default domain name of the MBean Server.  
+     * Get domain name for Camel MBeans.
+     * <p/>
+     * <b>Notice:</b> That this can be different that the default domain name of the MBean Server.
      * 
      * @return domain name
      */
     String getMBeanObjectDomainName();
 
-
 }

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/Language.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/Language.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/Language.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/Language.java Sat Aug 23 01:54:47 2008
@@ -27,7 +27,19 @@
  */
 public interface Language {
 
+    /**
+     * Creates a predicate based on the given string input
+     *
+     * @param expression  the expression
+     * @return the created predicate
+     */
     Predicate<Exchange> createPredicate(String expression);
 
+    /**
+     * Creates an expression based on the given string input
+     *
+     * @param expression  the expression as a string input
+     * @return the created expression
+     */
     Expression<Exchange> createExpression(String expression);
 }

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/LanguageResolver.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/LanguageResolver.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/LanguageResolver.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/LanguageResolver.java Sat Aug 23 01:54:47 2008
@@ -24,5 +24,13 @@
  * @version $Revision$
  */
 public interface LanguageResolver {
+
+    /**
+     * Resolves the given language.
+     *
+     * @param name    the name of the langauge
+     * @param context the camel context
+     * @return the resolved language
+     */
     Language resolveLanguage(String name, CamelContext context);
 }

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/LifecycleStrategy.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/LifecycleStrategy.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/LifecycleStrategy.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/LifecycleStrategy.java Sat Aug 23 01:54:47 2008
@@ -25,33 +25,43 @@
 import org.apache.camel.Service;
 
 /**
- * Strategy for notifications
+ * Strategy for lifecycle notifications.
  */
 public interface LifecycleStrategy {
+
     /**
      * Notification on starting a {@link CamelContext}.
+     *
+     * @param context the camel context
      */
     void onContextStart(CamelContext context);
 
     /**
      * Notification on adding an {@link Endpoint}.
+     *
+     * @param endpoint the added endpoint
      */
     void onEndpointAdd(Endpoint<? extends Exchange> endpoint);
 
     /**
      * Notification on adding a {@link Service}.
+     *
+     * @param context the camel context
+     * @param service the added service
      */
     void onServiceAdd(CamelContext context, Service service);
 
     /**
      * Notification on adding {@link Route}(s).
+     *
+     * @param routes the added routes
      */
     void onRoutesAdd(Collection<Route> routes);
 
     /**
      * Notification on adding {@link RouteContext}(s).
      *
-     * @param routeContext
+     * @param routeContext the added route context
      */
     void onRouteContextCreate(RouteContext routeContext);
 }

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/Provider.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/Provider.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/Provider.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/Provider.java Sat Aug 23 01:54:47 2008
@@ -25,6 +25,8 @@
 
     /**
      * Returns the newly constructed instance
+     *
+     * @return the newly constructed instance
      */
     T get();
 }

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/RouteContext.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/RouteContext.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/RouteContext.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/RouteContext.java Sat Aug 23 01:54:47 2008
@@ -34,31 +34,66 @@
  */
 public interface RouteContext {
 
+    /**
+     * Gets the endpoint
+     *
+     * @return the endpoint
+     */
     Endpoint<? extends Exchange> getEndpoint();
 
+    /**
+     * Gets the from type
+     *
+     * @return the from type
+     */
     FromType getFrom();
 
+    /**
+     * Get the route type
+     *
+     * @return the route type
+     */
     RouteType getRoute();
 
     /**
-     * Gets the CamelContext
+     * Gets the camel context
+     *
+     * @return the camel context
      */
     CamelContext getCamelContext();
 
+    /**
+     * Creates a processor
+     *
+     * @param node  the node
+     * @return the created processor
+     * @throws Exception can be thrown
+     */
     Processor createProcessor(ProcessorType node) throws Exception;
 
     /**
      * Resolves an endpoint from the URI
+     *
+     * @param uri the URI
+     * @return the resolved endpoint
      */
     Endpoint<? extends Exchange> resolveEndpoint(String uri);
 
     /**
      * Resolves an endpoint from either a URI or a named reference
+     *
+     * @param uri  the URI or
+     * @param ref  the named reference
+     * @return the resolved endpoint
      */
     Endpoint<? extends Exchange> resolveEndpoint(String uri, String ref);
 
     /**
      * lookup an object by name and type
+     *
+     * @param name  the name to lookup
+     * @param type  the expected type
+     * @return the found object
      */
     <T> T lookup(String name, Class<T> type);
 
@@ -68,31 +103,59 @@
      */
     void commit();
 
+    /**
+     * Adds an event driven processor
+     *
+     * @param processor the processor
+     */
     void addEventDrivenProcessor(Processor processor);
 
+    /**
+     * Intercepts with the given interceptor
+     *
+     * @param interceptor the interceptor
+     */
     void intercept(Intercept interceptor);
 
+    /**
+     * Creates a proceed processor
+     *
+     * @return the created proceed processor
+     */
     Processor createProceedProcessor();
 
     /**
      * This method retrieves the InterceptStrategy instances this route context.
+     *
+     * @return the strategy
      */
     List<InterceptStrategy> getInterceptStrategies();
 
     /**
      * This method sets the InterceptStrategy instances on this route context.
+     *
+     * @param interceptStrategies the strategies
      */
     void setInterceptStrategies(List<InterceptStrategy> interceptStrategies);
 
+    /**
+     * Adds a InterceptStrategy to this route context
+     *
+     * @param interceptStrategy the strategy
+     */
     void addInterceptStrategy(InterceptStrategy interceptStrategy);
 
     /**
      * This method retrieves the ErrorHandlerWrappingStrategy.
+     *
+     * @return the strategy
      */
     ErrorHandlerWrappingStrategy getErrorHandlerWrappingStrategy();
     
     /**
      * This method sets the ErrorHandlerWrappingStrategy.
+     *
+     * @param strategy the strategy
      */
     void setErrorHandlerWrappingStrategy(ErrorHandlerWrappingStrategy strategy);
 
@@ -100,10 +163,16 @@
      * If this flag is true, {@link ProcessorType#addRoutes(RouteContext, java.util.Collection)}
      * will not add processor to addEventDrivenProcessor to the RouteContext and it
      * will prevent from adding an EventDrivenRoute.
-     * 
+     *
+     * @param value the flag
      */
     void setIsRouteAdded(boolean value);
-    
+
+    /**
+     * Returns the isRouteAdded flag
+     * 
+     * @return the flag
+     */
     boolean isRouteAdded();
 
 }

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/Synchronization.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/Synchronization.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/Synchronization.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/Synchronization.java Sat Aug 23 01:54:47 2008
@@ -23,7 +23,8 @@
 /**
  * Provides a hook for custom {@link Processor} or {@link Component} instances to respond to
  * completed or failed processing of an {@link Exchange} rather like Spring's
- * <a href="http://static.springframework.org/spring/docs/2.0.x/api/org/springframework/transaction/support/TransactionSynchronization.html">TransactionSynchronization</a>
+ * <a href="http://static.springframework.org/spring/docs/2.5.x/api/org/springframework/transaction/
+ * support/TransactionSynchronization.html">TransactionSynchronization</a>
  *
  * @version $Revision$
  */

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/TypeConverterAware.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/TypeConverterAware.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/TypeConverterAware.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/TypeConverterAware.java Sat Aug 23 01:54:47 2008
@@ -27,5 +27,11 @@
  * @version $Revision$
  */
 public interface TypeConverterAware {
+
+    /**
+     * Injects the root type converter.
+     *
+     * @param parentTypeConverter the root type converter
+     */
     void setTypeConverter(TypeConverter parentTypeConverter);
 }

Modified: activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/UnitOfWork.java
URL: http://svn.apache.org/viewvc/activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/UnitOfWork.java?rev=688279&r1=688278&r2=688279&view=diff
==============================================================================
--- activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/UnitOfWork.java (original)
+++ activemq/camel/trunk/camel-core/src/main/java/org/apache/camel/spi/UnitOfWork.java Sat Aug 23 01:54:47 2008
@@ -29,21 +29,29 @@
 
     /**
      * Adds a synchronization hook
+     *
+     * @param synchronization  the hook
      */
     void addSynchronization(Synchronization synchronization);
 
     /**
      * Removes a synchronization hook
+     *
+     * @param synchronization  the hook
      */
     void removeSynchronization(Synchronization synchronization);
 
     /**
      * Invoked when this unit of work has been completed, whether it has failed or completed
+     *
+     * @param exchange the current exchange
      */
     void done(Exchange exchange);
 
     /**
      * Returns the unique ID of this unit of work, lazily creating one if it does not yet have one
+     * 
+     * @return the unique ID
      */
     String getId();
 }