You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/05/04 09:13:26 UTC
[GitHub] [hudi] dongkelun opened a new pull request, #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
dongkelun opened a new pull request, #5495:
URL: https://github.com/apache/hudi/pull/5495
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
Filter the properties should not be used when create table for Spark SQL
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5495:
URL: https://github.com/apache/hudi/pull/5495#issuecomment-1117100833
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c61e3471fc94c4928c52bd202d193f1824e506a1 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5495:
URL: https://github.com/apache/hudi/pull/5495#issuecomment-1117103833
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8419",
"triggerID" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c61e3471fc94c4928c52bd202d193f1824e506a1 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8419)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on a diff in pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
dongkelun commented on code in PR #5495:
URL: https://github.com/apache/hudi/pull/5495#discussion_r873477947
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala:
##########
@@ -360,6 +381,84 @@ class TestCreateTable extends TestHoodieSqlBase {
}
}
+ test("Test Create Table As Select With Tblproperties For Filter Props") {
+ Seq("cow", "mor").foreach { tableType =>
+ val tableName = generateTableName
+ spark.sql(
+ s"""
Review Comment:
> This SQL makes me confused. Should the table identifier be consistent with the property of "hoodie.database.name" ?
>
> I mean the CTAS should start with "create table databaseName.$tableName"
It doesn't have to be set. It has a default value in `HoodieCatalogTable`
```scala
val hoodieDatabaseName = formatName(spark, table.identifier.database.getOrElse(spark.sessionState.catalog.getCurrentDatabase))
HoodieTableMetaClient.withPropertyBuilder()
.fromProperties(properties)
.setDatabaseName(hoodieDatabaseName)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on a diff in pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
dongkelun commented on code in PR #5495:
URL: https://github.com/apache/hudi/pull/5495#discussion_r873487188
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala:
##########
@@ -360,6 +381,84 @@ class TestCreateTable extends TestHoodieSqlBase {
}
}
+ test("Test Create Table As Select With Tblproperties For Filter Props") {
+ Seq("cow", "mor").foreach { tableType =>
+ val tableName = generateTableName
+ spark.sql(
+ s"""
Review Comment:
`hoodie.database.name` is consistent with the table identifier, not the table identifier consistent with `hoodie.database.name`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] jinxing64 commented on a diff in pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
jinxing64 commented on code in PR #5495:
URL: https://github.com/apache/hudi/pull/5495#discussion_r873433227
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala:
##########
@@ -360,6 +381,84 @@ class TestCreateTable extends TestHoodieSqlBase {
}
}
+ test("Test Create Table As Select With Tblproperties For Filter Props") {
+ Seq("cow", "mor").foreach { tableType =>
+ val tableName = generateTableName
+ spark.sql(
+ s"""
+ | create table $tableName using hudi
+ | partitioned by (dt)
+ | tblproperties(
Review Comment:
I think the database at this moment is not created. Test should fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] jinxing64 commented on a diff in pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
jinxing64 commented on code in PR #5495:
URL: https://github.com/apache/hudi/pull/5495#discussion_r873464483
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala:
##########
@@ -360,6 +381,84 @@ class TestCreateTable extends TestHoodieSqlBase {
}
}
+ test("Test Create Table As Select With Tblproperties For Filter Props") {
+ Seq("cow", "mor").foreach { tableType =>
+ val tableName = generateTableName
+ spark.sql(
+ s"""
Review Comment:
This SQL makes me confused.
Should the table identifier be consistent with the property of "hoodie.database.name" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5495:
URL: https://github.com/apache/hudi/pull/5495#issuecomment-1117382570
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8419",
"triggerID" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"triggerType" : "PUSH"
}, {
"hash" : "f4d769501949a48c8b4247ed817c2746357833eb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8420",
"triggerID" : "f4d769501949a48c8b4247ed817c2746357833eb",
"triggerType" : "PUSH"
}, {
"hash" : "f4d769501949a48c8b4247ed817c2746357833eb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8420",
"triggerID" : "1117349404",
"triggerType" : "MANUAL"
}, {
"hash" : "eb986f7d06692d7232aa3b18f49de270855bb628",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "eb986f7d06692d7232aa3b18f49de270855bb628",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d769501949a48c8b4247ed817c2746357833eb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8420)
* eb986f7d06692d7232aa3b18f49de270855bb628 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5495:
URL: https://github.com/apache/hudi/pull/5495#issuecomment-1117378133
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8419",
"triggerID" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"triggerType" : "PUSH"
}, {
"hash" : "f4d769501949a48c8b4247ed817c2746357833eb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8420",
"triggerID" : "f4d769501949a48c8b4247ed817c2746357833eb",
"triggerType" : "PUSH"
}, {
"hash" : "f4d769501949a48c8b4247ed817c2746357833eb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "1117349404",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f4d769501949a48c8b4247ed817c2746357833eb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8420)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5495:
URL: https://github.com/apache/hudi/pull/5495#issuecomment-1117202275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8419",
"triggerID" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"triggerType" : "PUSH"
}, {
"hash" : "f4d769501949a48c8b4247ed817c2746357833eb",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8420",
"triggerID" : "f4d769501949a48c8b4247ed817c2746357833eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c61e3471fc94c4928c52bd202d193f1824e506a1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8419)
* f4d769501949a48c8b4247ed817c2746357833eb Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8420)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5495:
URL: https://github.com/apache/hudi/pull/5495#issuecomment-1117309762
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8419",
"triggerID" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"triggerType" : "PUSH"
}, {
"hash" : "f4d769501949a48c8b4247ed817c2746357833eb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8420",
"triggerID" : "f4d769501949a48c8b4247ed817c2746357833eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d769501949a48c8b4247ed817c2746357833eb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8420)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] jinxing64 commented on pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
jinxing64 commented on PR #5495:
URL: https://github.com/apache/hudi/pull/5495#issuecomment-1127346015
@XuQianJin-Stars
Fired an JIRA https://issues.apache.org/jira/browse/HUDI-4103
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] XuQianJin-Stars commented on pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars commented on PR #5495:
URL: https://github.com/apache/hudi/pull/5495#issuecomment-1127329284
hi @dongkelun track down this error https://github.com/apache/hudi/runs/6445032131?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
dongkelun commented on PR #5495:
URL: https://github.com/apache/hudi/pull/5495#issuecomment-1117349404
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5495:
URL: https://github.com/apache/hudi/pull/5495#issuecomment-1117387447
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8419",
"triggerID" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"triggerType" : "PUSH"
}, {
"hash" : "f4d769501949a48c8b4247ed817c2746357833eb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8420",
"triggerID" : "f4d769501949a48c8b4247ed817c2746357833eb",
"triggerType" : "PUSH"
}, {
"hash" : "f4d769501949a48c8b4247ed817c2746357833eb",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8420",
"triggerID" : "1117349404",
"triggerType" : "MANUAL"
}, {
"hash" : "eb986f7d06692d7232aa3b18f49de270855bb628",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8422",
"triggerID" : "eb986f7d06692d7232aa3b18f49de270855bb628",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f4d769501949a48c8b4247ed817c2746357833eb Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8420)
* eb986f7d06692d7232aa3b18f49de270855bb628 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8422)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] jinxing64 commented on a diff in pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
jinxing64 commented on code in PR #5495:
URL: https://github.com/apache/hudi/pull/5495#discussion_r873433227
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala:
##########
@@ -360,6 +381,84 @@ class TestCreateTable extends TestHoodieSqlBase {
}
}
+ test("Test Create Table As Select With Tblproperties For Filter Props") {
+ Seq("cow", "mor").foreach { tableType =>
+ val tableName = generateTableName
+ spark.sql(
+ s"""
+ | create table $tableName using hudi
+ | partitioned by (dt)
+ | tblproperties(
Review Comment:
I think the database at this moment is not created. Test should fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] dongkelun commented on a diff in pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
dongkelun commented on code in PR #5495:
URL: https://github.com/apache/hudi/pull/5495#discussion_r873477947
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala:
##########
@@ -360,6 +381,84 @@ class TestCreateTable extends TestHoodieSqlBase {
}
}
+ test("Test Create Table As Select With Tblproperties For Filter Props") {
+ Seq("cow", "mor").foreach { tableType =>
+ val tableName = generateTableName
+ spark.sql(
+ s"""
Review Comment:
> This SQL makes me confused. Should the table identifier be consistent with the property of "hoodie.database.name" ?
>
> I mean the CTAS should start with "create table databaseName.$tableName"
It doesn't have to be set. It has a default value in `HoodieCatalogTable`
```scala
val hoodieDatabaseName = formatName(spark, table.identifier.database.getOrElse(spark.sessionState.catalog.getCurrentDatabase))
HoodieTableMetaClient.withPropertyBuilder()
.fromProperties(properties)
.setDatabaseName(hoodieDatabaseName)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5495:
URL: https://github.com/apache/hudi/pull/5495#issuecomment-1117167050
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8419",
"triggerID" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c61e3471fc94c4928c52bd202d193f1824e506a1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8419)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #5495:
URL: https://github.com/apache/hudi/pull/5495#issuecomment-1123856978
@XuQianJin-Stars : can you review this patch please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] XuQianJin-Stars merged pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
XuQianJin-Stars merged PR #5495:
URL: https://github.com/apache/hudi/pull/5495
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] jinxing64 commented on a diff in pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
jinxing64 commented on code in PR #5495:
URL: https://github.com/apache/hudi/pull/5495#discussion_r873464483
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/spark/sql/hudi/TestCreateTable.scala:
##########
@@ -360,6 +381,84 @@ class TestCreateTable extends TestHoodieSqlBase {
}
}
+ test("Test Create Table As Select With Tblproperties For Filter Props") {
+ Seq("cow", "mor").foreach { tableType =>
+ val tableName = generateTableName
+ spark.sql(
+ s"""
Review Comment:
This SQL makes me confused.
Should the table identifier be consistent with the property of "hoodie.database.name" ?
I mean the CTAS should start with "create table databaseName.$tableName"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5495:
URL: https://github.com/apache/hudi/pull/5495#issuecomment-1117199765
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8419",
"triggerID" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"triggerType" : "PUSH"
}, {
"hash" : "f4d769501949a48c8b4247ed817c2746357833eb",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f4d769501949a48c8b4247ed817c2746357833eb",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* c61e3471fc94c4928c52bd202d193f1824e506a1 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8419)
* f4d769501949a48c8b4247ed817c2746357833eb UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5495: [HUDI-4001] Filter the properties should not be used when create table for Spark SQL
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5495:
URL: https://github.com/apache/hudi/pull/5495#issuecomment-1117554758
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8419",
"triggerID" : "c61e3471fc94c4928c52bd202d193f1824e506a1",
"triggerType" : "PUSH"
}, {
"hash" : "f4d769501949a48c8b4247ed817c2746357833eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8420",
"triggerID" : "f4d769501949a48c8b4247ed817c2746357833eb",
"triggerType" : "PUSH"
}, {
"hash" : "f4d769501949a48c8b4247ed817c2746357833eb",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8420",
"triggerID" : "1117349404",
"triggerType" : "MANUAL"
}, {
"hash" : "eb986f7d06692d7232aa3b18f49de270855bb628",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8422",
"triggerID" : "eb986f7d06692d7232aa3b18f49de270855bb628",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eb986f7d06692d7232aa3b18f49de270855bb628 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8422)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org