[jira] [Commented] (GEODE-3259) Refactor DurableClientCommands

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GEODE-3259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16117067#comment-16117067 ] 

ASF GitHub Bot commented on GEODE-3259:
---------------------------------------

GitHub user YehEmily opened a pull request:

    https://github.com/apache/geode/pull/689

    GEODE-3259: Refactoring DurableClientCommands

    [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-3259)
    
    `DurableClientCommands` was a huge class that contained a large number of commands. These commands have been split into their own individual command classes. The methods shared by these commands all appeared to be used for building results, so they were moved to a new class named `DurableClientCommandsResultBuilder`.
    
    **TESTING STATUS: Precheckin in progress**
    
    - [x] JIRA ticket referenced
    
    - [x] PR rebased
    
    - [x] Initial commit is single and squashed
    
    - [x] `gradlew build` runs cleanly
    
    - [ ] Unit tests will be updated with [GEODE-1359](https://issues.apache.org/jira/browse/GEODE-1359))

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/YehEmily/geode GEODE-3259

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/geode/pull/689.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #689
    
----

----


> Refactor DurableClientCommands
> ------------------------------
>
>                 Key: GEODE-3259
>                 URL: https://issues.apache.org/jira/browse/GEODE-3259
>             Project: Geode
>          Issue Type: Sub-task
>          Components: gfsh
>            Reporter: Emily Yeh
>            Assignee: Emily Yeh
>
> {{DurableClientCommands.java}} is a large class that contains multiple commands. Each command should be refactored into a separate class, and the methods shared by the commands should be refactored into a new and appropriately named class of their own.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)